Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(list): minification-safe element type comparison #509

Merged
merged 3 commits into from Dec 11, 2018

Conversation

dan-kwiat
Copy link
Contributor

@dan-kwiat dan-kwiat commented Dec 11, 2018

#492
I didn't have a chance to test this - please do so before merging

@codecov-io
Copy link

codecov-io commented Dec 11, 2018

Codecov Report

Merging #509 into rc0.8.0 will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##           rc0.8.0     #509   +/-   ##
========================================
  Coverage    96.62%   96.62%           
========================================
  Files           59       59           
  Lines         1984     1984           
  Branches       235      235           
========================================
  Hits          1917     1917           
  Misses          67       67
Impacted Files Coverage Δ
packages/list/index.js 89.09% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0830172...dd1667c. Read the comment docs.

@moog16
Copy link
Contributor

moog16 commented Dec 11, 2018

@dan-kwiat I tested this by

  1. using master, and adding the edits in this PR.
  2. ran npm run build && node scripts/release/cp-pkgs.js
  3. copied the /List/dist/index.js file to your <https://github.com/dan-kwiat/material-next-template>node_modules/@material/react-list/dist/index.js file
  4. I ran yarn export from your material-next-template
  5. replaced all instances of /material-next-template/ in the index.html
  6. opened index.html

IT WORKED! Thanks again

@moog16 moog16 changed the base branch from master to rc0.8.0 December 11, 2018 18:30
@moog16
Copy link
Contributor

moog16 commented Dec 11, 2018

TESTS: #511

@moog16
Copy link
Contributor

moog16 commented Dec 11, 2018

@dan-kwiat while we wait for tests please sign the PR by commenting "I signed it"

@moog16
Copy link
Contributor

moog16 commented Dec 11, 2018

@dan-kwiat can you please add the line found in d7981e2

@dan-kwiat
Copy link
Contributor Author

I signed it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants