-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ripple: HTMLElement is not defined on SSR #581
Comments
Thanks for opening the issue..SSR isn't something we're setup for testing, but i'm sure a lot of people out there are using it. Please open PR if you have time. I also opened issue #588 since you're the 4th issue regarding SSR. |
sweet! ya don't worry too much about exploring how RMWC tests SSR. I will be looking into...eventually. I need to meet with the team to see where it fits into 2019. |
As promised, PR submitted! 😉 (First one closed because I forgot to create a new non-master branch.) |
Thanks :) |
closing as #592 was merged. Thanks again! |
Hello,
With the changeover to TS in
v0.8.0
, the following line went from being scoped within a function to not:In SSR React apps, this will result in an
HTMLElement is not defined
error, because it's not evaluated in a browser whereHTMLElement
would exist.The following line, when added just before the line above, resolves the issue locally:
However, I'm not sure this is an appropriate solution outside of my use case. If this addition would suffice, I can submit a PR for it. Let me know! Thanks! 😄
The text was updated successfully, but these errors were encountered: