Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(top-app-bar): make top app bar props optional #587

Merged
merged 2 commits into from Jan 4, 2019
Merged

fix(top-app-bar): make top app bar props optional #587

merged 2 commits into from Jan 4, 2019

Conversation

moog16
Copy link
Contributor

@moog16 moog16 commented Jan 2, 2019

fixes #583

@moog16 moog16 mentioned this pull request Jan 2, 2019
Closed
@moog16 moog16 added this to the 0.9.0 milestone Jan 2, 2019
@moog16 moog16 assigned moog16 and bonniezhou and unassigned moog16 Jan 4, 2019
@codecov-io
Copy link

Codecov Report

Merging #587 into rc0.9.0 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           rc0.9.0     #587   +/-   ##
========================================
  Coverage    94.45%   94.45%           
========================================
  Files           61       61           
  Lines         2561     2561           
  Branches       372      372           
========================================
  Hits          2419     2419           
  Misses          50       50           
  Partials        92       92
Impacted Files Coverage Δ
packages/top-app-bar/index.tsx 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c7b64d4...cbb1559. Read the comment docs.

@moog16 moog16 merged commit 1e30708 into rc0.9.0 Jan 4, 2019
@moog16 moog16 deleted the fix/topappbar/makeoptional branch January 4, 2019 23:43
moog16 pushed a commit that referenced this pull request Jan 23, 2019
fix(top-app-bar): make top app bar props optional (#587)
1585c95
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bonniezhou bonniezhou bonniezhou approved these changes

Assignees

@bonniezhou bonniezhou

Labels
None yet
Projects
None yet
Milestone
0.9.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@moog16 @codecov-io @bonniezhou