Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade resemblejs to v3 #634

Merged
merged 1 commit into from Jan 28, 2019
Merged

Conversation

gugu
Copy link
Contributor

@gugu gugu commented Jan 25, 2019

v2 uses outdated canvas, which does not build on latest Ubuntu

v2 uses outdated canvas, which does not build on latest Ubuntu
@codecov-io
Copy link

codecov-io commented Jan 25, 2019

Codecov Report

Merging #634 into rc0.10.0 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           rc0.10.0     #634   +/-   ##
=========================================
  Coverage     94.83%   94.83%           
=========================================
  Files            67       67           
  Lines          2768     2768           
  Branches        414      414           
=========================================
  Hits           2625     2625           
  Misses           50       50           
  Partials         93       93

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b80188...50050b8. Read the comment docs.

@moog16 moog16 changed the base branch from master to rc0.10.0 January 25, 2019 17:35
Copy link
Contributor

@moog16 moog16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@moog16
Copy link
Contributor

moog16 commented Jan 25, 2019

@gugu in order for tests to run, you need to water with rc0.10.0 (the working feature branch)

@gugu
Copy link
Contributor Author

gugu commented Jan 25, 2019

Done

@moog16
Copy link
Contributor

moog16 commented Jan 28, 2019

opened pr for tests #641

@moog16 moog16 merged commit 8ab8708 into material-components:rc0.10.0 Jan 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants