Fix screenshot tests for external contributors and pull requests #638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v2 uses outdated canvas, which does not build on latest Ubuntu
Codecov Report
@@ Coverage Diff @@
## rc0.10.0 #638 +/- ##
=========================================
Coverage 94.83% 94.83%
=========================================
Files 67 67
Lines 2768 2768
Branches 414 414
=========================================
Hits 2625 2625
Misses 50 50
Partials 93 93Continue to review full report at Codecov.
|
|
Aaaand... it's green |
|
@gugu can you change base to rc0.10.0. Reviewing right now |
moog16
suggested changes
Jan 28, 2019
moog16
reviewed
Jan 28, 2019
| @@ -5,11 +5,6 @@ git: | |||
| dist: trusty | |||
| sudo: required | |||
|
|
|||
| branches: | |||
There was a problem hiding this comment.
there is also a piece in the release readme. Can you please update.
moog16
approved these changes
Jan 28, 2019
|
Approved changes once the release readme is updated. Thanks so much @gugu ! |
|
@moog16 do you mean to remove this section? |
|
@gugu yes. I just meant to edit at your discretion |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed:
This means if no UI changes, screenshot tests will pass. Goldens will still need to be uploaded manually