Feat/fab/exited #661
Merged
Feat/fab/exited #661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## rc0.10.0 #661 +/- ##
===========================================
+ Coverage 94.8% 94.8% +<.01%
===========================================
Files 68 68
Lines 2849 2850 +1
Branches 429 430 +1
===========================================
+ Hits 2701 2702 +1
Misses 51 51
Partials 97 97
Continue to review full report at Codecov.
|
moog16
approved these changes
Feb 7, 2019
moog16
pushed a commit
that referenced
this pull request
Feb 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#658 and #660
added screenshot test, but as always, golden.json not updated :(
Why Both?
Because I needed #660 for my screenshot tests.
I signed it