Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(checkbox): enable name attribute #678

Merged

Conversation

nicklasisraelsson
Copy link
Contributor

This is a suggested interim solution until issue #438 can be resolved to be able to use Checkbox components in forms.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

Googlers can find more info about SignCLA and this PR by following this link.

@codecov-io
Copy link

codecov-io commented Feb 15, 2019

Codecov Report

Merging #678 into rc0.10.0 will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##           rc0.10.0     #678      +/-   ##
============================================
+ Coverage     94.88%   94.88%   +<.01%     
============================================
  Files            68       68              
  Lines          2852     2853       +1     
  Branches        432      432              
============================================
+ Hits           2706     2707       +1     
  Misses           50       50              
  Partials         96       96
Impacted Files Coverage Δ
packages/checkbox/index.tsx 89.33% <100%> (+0.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02da75c...57ba49d. Read the comment docs.

@nicklasisraelsson
Copy link
Contributor Author

I signed it!

Copy link
Contributor

@moog16 moog16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good - thanks for adding a test.

@moog16 moog16 merged commit a79dc3a into material-components:rc0.10.0 Feb 15, 2019
@moog16
Copy link
Contributor

moog16 commented Feb 15, 2019

cla not passing - signed in #678 (comment)

moog16 pushed a commit that referenced this pull request Feb 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants