fix(ripple): Use mdc-dom.matches instead of getMatchesProperty()
#706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdc-dom is implementing a `matches` method that wasn't used everywhere. `getMatchesProperty()` will be removed in the next release of mdc-web. It prevented some SSR usage of the material-components library. This commit replaces `getMatchesProperty()` usage by `matches`.
Codecov Report
@@ Coverage Diff @@
## rc0.11.0 #706 +/- ##
============================================
+ Coverage 94.98% 95.18% +0.19%
============================================
Files 73 73
Lines 2912 2905 -7
Branches 444 441 -3
============================================
- Hits 2766 2765 -1
+ Misses 50 45 -5
+ Partials 96 95 -1
Continue to review full report at Codecov.
|
|
I was about to create this PR 😅but nice to see! |
moog16
pushed a commit
that referenced
this pull request
Mar 18, 2019
moog16
pushed a commit
that referenced
this pull request
Mar 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mdc-dom is implementing a
matchesmethod that wasn't used everywhere.getMatchesProperty()will be removed in the next release of mdc-web by material-components/material-components-web#4372.It prevented some SSR usage of the material-components library.
This commit replaces
getMatchesProperty()usage bymatches.It will partially resolve #654.