Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dialog): should extend HTMLElement #723

Merged

Conversation

mgr34
Copy link
Contributor

@mgr34 mgr34 commented Mar 7, 2019

successful merge closes #696


I signed it

@codecov-io
Copy link

Codecov Report

Merging #723 into rc0.11.0 will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           rc0.11.0     #723   +/-   ##
=========================================
  Coverage     95.18%   95.18%           
=========================================
  Files            73       73           
  Lines          2905     2905           
  Branches        441      441           
=========================================
  Hits           2765     2765           
  Misses           45       45           
  Partials         95       95
Impacted Files Coverage Δ
packages/dialog/DialogTitle.tsx 100% <ø> (ø) ⬆️
packages/dialog/DialogFooter.tsx 100% <ø> (ø) ⬆️
packages/dialog/DialogContent.tsx 100% <ø> (ø) ⬆️
packages/dialog/index.tsx 99.29% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1827385...181e303. Read the comment docs.

Copy link
Contributor

@moog16 moog16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for following up! LGTM

@moog16 moog16 merged commit 9665f7f into material-components:rc0.11.0 Mar 8, 2019
@moog16 moog16 modified the milestone: 0.11.0 Mar 8, 2019
moog16 pushed a commit that referenced this pull request Mar 18, 2019
moog16 pushed a commit that referenced this pull request Mar 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants