Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(infrastructure): remove duplicate tsconfig properties #736

Merged
merged 2 commits into from Mar 13, 2019

Conversation

moog16
Copy link
Contributor

@moog16 moog16 commented Mar 12, 2019

  • strictNullChecks is set to true in strict = true, which is set in gts/tsconfig-google.json
  • forceConsistentCasingInFileNames is set to true in gts/tsconfig-google.json

for reference
https://github.com/google/gts/blob/master/tsconfig-google.json

@codecov-io
Copy link

codecov-io commented Mar 12, 2019

Codecov Report

Merging #736 into rc0.11.0 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           rc0.11.0     #736   +/-   ##
=========================================
  Coverage     95.16%   95.16%           
=========================================
  Files            73       73           
  Lines          2914     2914           
  Branches        442      442           
=========================================
  Hits           2773     2773           
  Misses           46       46           
  Partials         95       95

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce10503...a452035. Read the comment docs.

@moog16 moog16 merged commit d54ae23 into rc0.11.0 Mar 13, 2019
@moog16 moog16 deleted the fix/tsconfig/remove-duplicate-props branch March 13, 2019 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants