fix: make require props optional #737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moog16
commented
Mar 12, 2019
| open: boolean; | ||
| onOpen: () => void; | ||
| onClose: () => void; | ||
| onTransitionEnd: React.TransitionEventHandler<HTMLElement>; |
There was a problem hiding this comment.
removed these since they are duplicates covered in HTMLProps.
moog16
changed the title
Codecov Report
@@ Coverage Diff @@
## rc0.11.0 #737 +/- ##
=========================================
Coverage 95.16% 95.16%
=========================================
Files 73 73
Lines 2914 2914
Branches 442 442
=========================================
Hits 2773 2773
Misses 46 46
Partials 95 95
Continue to review full report at Codecov.
|
williamernest
approved these changes
Mar 13, 2019
moog16
pushed a commit
that referenced
this pull request
Mar 18, 2019
moog16
pushed a commit
that referenced
this pull request
Mar 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #734
This PR makes all props optional that were required.