Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add typography components #75

Closed
patrick91 opened this issue May 26, 2018 · 2 comments
Closed

Add typography components #75

patrick91 opened this issue May 26, 2018 · 2 comments

Comments

@patrick91
Copy link
Contributor

Would be nice to have components for the typography styles, we can create a base one that can be reused for titles, paragraphs and more:

<Typography type="XXX">
  Text
</Typography>

Where type can be one of the following:

  • headline1
  • headline2
  • headline3
  • headline4
  • headline5
  • headline6
  • subtitle1
  • subtitle2
  • body1
  • body2
  • caption
  • button
  • overline

We can also add components like:

<Title level={1}>Hey</Title>
<Subtitle level={1}>Hey</Subtitle>

and so on :) What do you think? Can I make a PR for this?

@moog16
Copy link
Contributor

moog16 commented Jun 6, 2018

@patrick91 I apologize for the late response. This is far off of our radar, and I haven't written a doc on how-to create a new component. But if you would like to give it a shot I'm definitely willing to work with you.

I like both ideas, but I like the <Typography /> option better. It is simpler to me to pass type as 'body1' or 'headline4' instead of doing or <Headline level='4' />. Also body, caption, button, etc are all common names. Example: is a very common component name, and that might not work for a lot of people.

@lynnmercier
Copy link
Contributor

We've decided not to build this feature. Its just not a high priority for us to wrap typography, because we've made successful React prototypes that use MDC Web typography simply through Sass.

But if you'd like to make your own React wrappers, in some other open source project, let us know! Because I think we would seriously consider adding that library to our main README.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants