fix(infrastructure): fixed npm run build error for empty package directories #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kfranqueiro
reviewed
May 31, 2018
packages/webpack.config.js
Outdated
| @@ -20,10 +20,12 @@ const path = require('path'); | |||
| const ExtractTextPlugin = require('extract-text-webpack-plugin'); | |||
|
|
|||
| const isDirectory = (source) => lstatSync(source).isDirectory(); | |||
| const containsJsFile = (source) => readdirSync(source).some(file => path.parse(file).ext === '.js'); | |||
There was a problem hiding this comment.
I think you can simplify path.parse(file).ext to path.extname(file)?
Codecov Report
@@ Coverage Diff @@
## master #85 +/- ##
======================================
Coverage 99.2% 99.2%
======================================
Files 18 18
Lines 632 632
Branches 51 51
======================================
Hits 627 627
Misses 5 5Continue to review full report at Codecov.
|
kfranqueiro
approved these changes
May 31, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #82
Error occurs when an empty directory exists in /packages ie. Chips.