fix(text-field): Update typography to subtitle1. Updated height and p…

…adding. (#2606) Adjusted the typography style to use subtitle1. Adjusted the height and padding to accommodate the larger line-height on subtitle1.
material-components · Apr 20, 2018 · 127375e · robbyrice · Apr 24, 2018 · chaficnajjar
1 parent 3d8a27b
commit 127375e
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 12 deletions.
diff --git a/packages/mdc-textfield/_mixins.scss b/packages/mdc-textfield/_mixins.scss
@@ -255,7 +255,6 @@
 
   .mdc-text-field__input {
     display: flex;
-    height: 30px;
     padding: 12px;
     border: none;
     background-color: transparent;

diff --git a/packages/mdc-textfield/mdc-text-field.scss b/packages/mdc-textfield/mdc-text-field.scss
@@ -49,24 +49,16 @@
 }
 
 .mdc-text-field__input {
-  @include mdc-typography-base;
-  // We use only a subset of the MDC typography values here as changing things such as line-height
-  // affects how the labels are transformed.
-  // TODO: Re-add setting the font-size from mdc-typography-styles (currently
-  // setting it here has no effect because it is overriden by the font-size
-  // given below).
-  @each $prop in (letter-spacing) {
-    #{$prop}: map-get(map-get($mdc-typography-styles, subtitle1), $prop);
-  }
+  @include mdc-typography(subtitle1);
 
   width: 100%;
-  padding: 20px 0 8px;
+  height: 30px;
+  padding: 20px 0 1px;
   transition: mdc-text-field-transition(opacity);
   border: none;
   border-bottom: 1px solid;
   border-radius: 0;
   background: none;
-  font-size: inherit;
   appearance: none;
 
   &::placeholder {