fix(list): removed the need of followHref

packages/mdc-list/README.md

@@ -499,13 +499,11 @@ Method Signature | Description
 `getListItemCount() => Number` | Returns the total number of list items (elements with `mdc-list-item` class) that are direct children of the `root_` element.
 `getFocusedElementIndex() => Number` | Returns the `index` value of the currently focused element.
 `getListItemIndex(ele: Element) => Number` | Returns the `index` value of the provided `ele` element.
-`getAttributeForElementIndex(index: number, attr: string) => string` | Gets the `attr` attribute value for the list item at `index`.
 `setAttributeForElementIndex(index: Number, attr: String, value: String) => void` | Sets the `attr` attribute to `value` for the list item at `index`.
 `addClassForElementIndex(index: Number, className: String) => void` | Adds the `className` class to the list item at `index`.
 `removeClassForElementIndex(index: Number, className: String) => void` | Removes the `className` class to the list item at `index`.
 `focusItemAtIndex(index: Number) => void` | Focuses the list item at the `index` value specified.
 `setTabIndexForListItemChildren(index: Number, value: Number) => void` | Sets the `tabindex` attribute to `value` for each child button or anchor element in the list item at the `index` specified.
-`followHref(element: Element) => void` | If the given element has an href, follows the link.
 `hasRadioAtIndex(index: number) => boolean` | Returns true if radio button is present at given list item index.
 `hasCheckboxAtIndex(index: number) => boolean` | Returns true if checkbox is present at given list item index.
 `isCheckboxCheckedAtIndex(index: number) => boolean` | Returns true if checkbox inside a list item is checked.

packages/mdc-list/adapter.js

@@ -44,12 +44,6 @@ class MDCListAdapter {
    * @return {number} */
   getFocusedElementIndex() {}
 
-  /**
-   * @param {number} index
-   * @param {string} attribute
-   */
-  getAttributeForElementIndex(index, attr) {}
-
   /**
    * @param {number} index
    * @param {string} attribute
@@ -89,12 +83,6 @@ class MDCListAdapter {
    */
   setTabIndexForListItemChildren(listItemIndex, tabIndexValue) {}
 
-  /**
-   * If the given element has an href, follows the link.
-   * @param {!Element} ele
-   */
-  followHref(ele) {}
-
   /**
    * @param {number} index
    * @return {boolean} Returns true if radio button is present at given list item index.

packages/mdc-list/foundation.js

@@ -47,14 +47,12 @@ class MDCListFoundation extends MDCFoundation {
     return /** @type {!MDCListAdapter} */ ({
       getListItemCount: () => {},
       getFocusedElementIndex: () => {},
-      getAttributeForElementIndex: () => {},
       setAttributeForElementIndex: () => {},
       removeAttributeForElementIndex: () => {},
       addClassForElementIndex: () => {},
       removeClassForElementIndex: () => {},
       focusItemAtIndex: () => {},
       setTabIndexForListItemChildren: () => {},
-      followHref: () => {},
       hasRadioAtIndex: () => {},
       hasCheckboxAtIndex: () => {},
       isCheckboxCheckedAtIndex: () => {},
@@ -251,6 +249,9 @@ class MDCListFoundation extends MDCFoundation {
       this.focusLastElement();
     } else if (isEnter || isSpace) {
       if (isRootListItem) {
+        // Return early if enter key is pressed on anchor element which triggers synthetic MouseEvent event.
+        if (evt.target.tagName === 'A' && isEnter) return;
+
         if (this.isSingleSelectionList_) {
           // Check if the space key was pressed on the list item or a child element.
           this.preventDefaultEvent_(evt);
@@ -266,12 +267,7 @@ class MDCListFoundation extends MDCFoundation {
           this.setSelectedIndex(currentIndex);
         }
 
-        // Explicitly activate links, since we're preventing default on Enter, and Space doesn't activate them.
-        if (this.adapter_.getAttributeForElementIndex(currentIndex, 'href')) {
-          this.adapter_.followHref(currentIndex);
-        } else {
-          this.adapter_.notifyAction(currentIndex);
-        }
+        this.adapter_.notifyAction(currentIndex);
       }
     }
   }

packages/mdc-list/index.js

@@ -206,7 +206,6 @@ class MDCList extends MDCComponent {
     return new MDCListFoundation(/** @type {!MDCListAdapter} */ (Object.assign({
       getListItemCount: () => this.listElements.length,
       getFocusedElementIndex: () => this.listElements.indexOf(document.activeElement),
-      getAttributeForElementIndex: (index, attr) => this.listElements[index].getAttribute(attr),
       setAttributeForElementIndex: (index, attr, value) => {
         const element = this.listElements[index];
         if (element) {
@@ -242,12 +241,6 @@ class MDCList extends MDCComponent {
         const listItemChildren = [].slice.call(element.querySelectorAll(strings.CHILD_ELEMENTS_TO_TOGGLE_TABINDEX));
         listItemChildren.forEach((ele) => ele.setAttribute('tabindex', tabIndexValue));
       },
-      followHref: (index) => {
-        const listItem = this.listElements[index];
-        if (listItem && listItem.href) {
-          listItem.click();
-        }
-      },
       hasCheckboxAtIndex: (index) => {
         const listItem = this.listElements[index];
         return !!listItem.querySelector(strings.CHECKBOX_SELECTOR);