Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement new ripple sizing requirements #187

Closed
traviskaufman opened this issue Jan 18, 2017 · 0 comments
Closed

Implement new ripple sizing requirements #187

traviskaufman opened this issue Jan 18, 2017 · 0 comments
Assignees
@cristobalchao
Labels
backlog

Comments

@traviskaufman
Copy link
Contributor

traviskaufman commented Jan 18, 2017 •
edited
Loading

Ensure that the overall size of the ripple is 10px larger than its surface area

Main logic that has to change: https://github.com/material-components/material-components-web/blob/master/packages/mdc-ripple/foundation.js#L373, where maxRadius_ should change.
@traviskaufman traviskaufman added this to the Beta milestone Jan 18, 2017
cristobalchao pushed a commit that referenced this issue Feb 2, 2017
feat(ripple): Implement new ripple sizing requirements
9518829 
Resolves #187
cristobalchao pushed a commit that referenced this issue Feb 2, 2017
feat(ripple): Implement new ripple sizing requirements
0948ed3 
Resolves #187
@cristobalchao cristobalchao mentioned this issue Feb 2, 2017
Merged
cristobalchao added a commit that referenced this issue Feb 2, 2017
@cristobalchao
feat(ripple): Implement new ripple sizing requirements (#244)
f0d26e6 
Resolves #187
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cristobalchao cristobalchao

Labels
backlog
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@traviskaufman @cristobalchao