Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(slider): Add MDCSliderFoundation export #1959

Merged
merged 2 commits into from
Jan 17, 2018
Merged

fix(slider): Add MDCSliderFoundation export #1959

merged 2 commits into from
Jan 17, 2018

Conversation

trimox
Copy link
Contributor

@trimox trimox commented Jan 13, 2018

Re-adds an MDCSliderFoundation export to index.js.

@codecov-io
Copy link

codecov-io commented Jan 13, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@815eade). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1959   +/-   ##
=========================================
  Coverage          ?   99.43%           
=========================================
  Files             ?       84           
  Lines             ?     3710           
  Branches          ?      484           
=========================================
  Hits              ?     3689           
  Misses            ?       21           
  Partials          ?        0
Impacted Files Coverage Δ
packages/mdc-slider/index.js 100% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 815eade...27e95f3. Read the comment docs.

Copy link
Contributor

@lynnmercier lynnmercier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@lynnmercier lynnmercier merged commit 3a1786f into material-components:master Jan 17, 2018
@trimox trimox deleted the patch-2 branch January 17, 2018 16:39
acdvorak added a commit that referenced this pull request Jan 17, 2018
commit bffadd3
Author: Andrew C. Dvorak <acdvorak@gmail.com>
Date:   Wed Jan 17 09:09:56 2018 -0800

    style(demos): Clean up theme demo Sass and HTML (#1973)

    - Remove unused code
    - IE 11 compatible property values (`unset` -> `auto`)
    - Fix duplicate IDs
    - Use `--stroked` buttons instead of `--raised` for checkbox demo
    - Rename CSS classes to be more BEM-y
    - Rename and reorganize Sass demo vars
    - Reword text-field labels and helper text for clarity
    - Remove `getAll()`
    - Inline some JS vars

commit 3a1786f
Author: Dominic Carretto <trimox@users.noreply.github.com>
Date:   Wed Jan 17 11:37:03 2018 -0500

    fix(slider): Add MDCSliderFoundation export (#1959)

commit 815eade
Author: Simon Olofsson <simon@olofsson.de>
Date:   Wed Jan 17 17:36:07 2018 +0100

    docs(menu): Remove obsolete `mdc-simple-menu--open-from` classes. (#1927)

commit 6078784
Author: Chafic Najjar <chafic.najjar@gmail.com>
Date:   Wed Jan 17 18:26:00 2018 +0200

    docs: Rewrite all instances of "MDC-Web" as "MDC Web" (#1960)

    Resolves #1924

commit e87c110
Author: pndewit <dodoiva@gmail.com>
Date:   Wed Jan 17 17:23:03 2018 +0100

    docs(drawer): Fix missing link to temporary drawer demo (#1922)

commit 003dff4
Author: Chafic Najjar <chafic.najjar@gmail.com>
Date:   Wed Jan 17 18:20:35 2018 +0200

    docs: Fix broken links to AngularJS's Git commit guidelines (#1888)
acdvorak added a commit that referenced this pull request Jan 17, 2018
commit 1e8970f
Author: Matty Goo <mattgoo@google.com>
Date:   Wed Jan 17 09:19:54 2018 -0800

    chore(text-field): moved textarea sass into private mixins (#1942)

commit bffadd3
Author: Andrew C. Dvorak <acdvorak@gmail.com>
Date:   Wed Jan 17 09:09:56 2018 -0800

    style(demos): Clean up theme demo Sass and HTML (#1973)

    - Remove unused code
    - IE 11 compatible property values (`unset` -> `auto`)
    - Fix duplicate IDs
    - Use `--stroked` buttons instead of `--raised` for checkbox demo
    - Rename CSS classes to be more BEM-y
    - Rename and reorganize Sass demo vars
    - Reword text-field labels and helper text for clarity
    - Remove `getAll()`
    - Inline some JS vars

commit 3a1786f
Author: Dominic Carretto <trimox@users.noreply.github.com>
Date:   Wed Jan 17 11:37:03 2018 -0500

    fix(slider): Add MDCSliderFoundation export (#1959)

commit 815eade
Author: Simon Olofsson <simon@olofsson.de>
Date:   Wed Jan 17 17:36:07 2018 +0100

    docs(menu): Remove obsolete `mdc-simple-menu--open-from` classes. (#1927)

commit 6078784
Author: Chafic Najjar <chafic.najjar@gmail.com>
Date:   Wed Jan 17 18:26:00 2018 +0200

    docs: Rewrite all instances of "MDC-Web" as "MDC Web" (#1960)

    Resolves #1924

commit e87c110
Author: pndewit <dodoiva@gmail.com>
Date:   Wed Jan 17 17:23:03 2018 +0100

    docs(drawer): Fix missing link to temporary drawer demo (#1922)

commit 003dff4
Author: Chafic Najjar <chafic.najjar@gmail.com>
Date:   Wed Jan 17 18:20:35 2018 +0200

    docs: Fix broken links to AngularJS's Git commit guidelines (#1888)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants