Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(checkbox): Fix background fading too fast #2122

Merged
merged 5 commits into from
Jan 29, 2018

Conversation

patrickrodee
Copy link
Contributor

Fix the checked to unchecked background fade animation which was causing the background to abruptly disappear instead of fade nicely.

Fix the checked to unchecked background fade animation which was causing the background to abruptly disappear instead of fade nicely.
@codecov-io
Copy link

codecov-io commented Jan 29, 2018

Codecov Report

Merging #2122 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2122   +/-   ##
=======================================
  Coverage   99.43%   99.43%           
=======================================
  Files          84       84           
  Lines        3723     3723           
  Branches      486      486           
=======================================
  Hits         3702     3702           
  Misses         21       21
Impacted Files Coverage Δ
packages/mdc-checkbox/constants.js 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a83568...1e10df0. Read the comment docs.

@acdvorak acdvorak self-assigned this Jan 29, 2018
Copy link
Contributor

@acdvorak acdvorak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@patrickrodee patrickrodee merged commit d461374 into master Jan 29, 2018
@kfranqueiro kfranqueiro deleted the fix/checkbox/checked-unchecked-bg-fade branch February 7, 2018 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants