fix(ripple): Prevent ancestors of nested ripple surfaces from activating #2123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2123 +/- ##
==========================================
+ Coverage 99.43% 99.43% +<.01%
==========================================
Files 84 84
Lines 3720 3723 +3
Branches 486 486
==========================================
+ Hits 3699 3702 +3
Misses 21 21
Continue to review full report at Codecov.
|
This was referenced Jan 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows JS-enhanced ripples to support nested surfaces (e.g. a checkbox within a list item) and avoid the ripple activating on both surfaces at once (it should only activate on the deepest surface interacted with).
Unfortunately this is probably not resolvable for CSS-only.