fix(text-field): Apply error color on bottom line of fullwidth field #2197
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2197 +/- ##
=======================================
Coverage 99.14% 99.14%
=======================================
Files 90 90
Lines 3842 3842
Branches 496 496
=======================================
Hits 3809 3809
Misses 33 33Continue to review full report at Codecov.
|
| @include mdc-text-field-fullwidth_; | ||
| } | ||
|
|
||
| .mdc-text-field--fullwidth.mdc-text-field--invalid { |
There was a problem hiding this comment.
When the alternate colors class is added, the idle line is still red.
There was a problem hiding this comment.
FWIW I would point out that the alternate color class was never doing anything to the idle bottom line color for the fullwidth text field, so this might actually be a separate issue, but I'm looking into it a bit.
There was a problem hiding this comment.
So this seems like it was more of an oversight with the demo page than with these styles. I added styles to the demo page for the full-width custom color demo, and also fixed a style for the textfield custom color demo that seemed accidentally redundant (idle/focus used same opacity).
I suspect that those styles could be further cleaned up; I initially ended up confused as to where to put the styles for this specific part of the demo page, and realized that the demo-text-field-custom-colors and demo-text-field-custom-error-colors styles probably don't actually need separate CSS classes since they're always applied together to the same elements...
Also fixes typos in a couple of private mixins (asterix -> asterisk, full-width -> fullwidth for consistency with other mixins incl. a public one)
Observable using the required checkbox under the fullwidth examples at the end of text-field.html.
Fixes #2165.