fix(text-field): Update typography #2606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2606 +/- ##
=======================================
Coverage 98.46% 98.46%
=======================================
Files 98 98
Lines 4233 4233
Branches 537 537
=======================================
Hits 4168 4168
Misses 65 65Continue to review full report at Codecov.
|
acdvorak
approved these changes
Apr 20, 2018
There was a problem hiding this comment.
Can we move the mdc-select stuff to its own PR? That way the CHANGELOG will be accurate.
Otherwise this LGTM!
I would suggest changing the PR description to something that explains what the end result is, like:
fix(text-field): Set `font-size` and `line-height` on native input element
lynnmercier
approved these changes
Apr 20, 2018
williamernest
force-pushed
the
fix/text-field/update-typography
branch
from
e71fa81
to
b1880a3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #2538
Updates the typography for select and text-field. Explicitly declares line-height instead of implicitly depending on normalize.css