Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(select): Fix invalid use of dropdown arrow mixin #2637

Merged
merged 3 commits into from
Apr 27, 2018

Conversation

williamernest
Copy link
Contributor

Fixes: #2636

@codecov-io
Copy link

codecov-io commented Apr 24, 2018

Codecov Report

Merging #2637 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2637   +/-   ##
=======================================
  Coverage   98.48%   98.48%           
=======================================
  Files          98       98           
  Lines        4230     4230           
  Branches      537      537           
=======================================
  Hits         4166     4166           
  Misses         64       64

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c05a6bd...7c6fa4a. Read the comment docs.

Copy link
Contributor

@kfranqueiro kfranqueiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving this since it fixes an issue... but I think we can simplify this whole situation.

Interestingly, I don't think the previous code was even generating a valid background-image value to begin with. It occurs to me that now this code is using on-surface, whereas the SCSS for the default arrow is hard-coding to black, which makes me wonder if we should actually be defaulting to on-surface and don't need to re-call the svg-bg mixin whatsoever? (The separate opacity rule seems to be doing all of the work.)

@williamernest williamernest merged commit 6450613 into master Apr 27, 2018
@williamernest williamernest deleted the fix/select/arrow-mixin branch April 27, 2018 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants