Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Snackbar Component #28

Closed
8 tasks done
traviskaufman opened this issue Dec 5, 2016 · 3 comments · Fixed by #852
Closed
8 tasks done

Implement Snackbar Component #28

traviskaufman opened this issue Dec 5, 2016 · 3 comments · Fixed by #852

Comments

@traviskaufman
Copy link
Contributor

traviskaufman commented Dec 5, 2016

Spec Reference: https://www.google.com/design/spec/components/snackbars-toasts.html

It's been called a "Toast" in the past, but the thing that's not Android-specific is a snackbar.

  • Initial Implementation
  • Dark Theme (background: #fafafa, text: text-primary-on-dark, action: theme primary color)
  • Keyboard Focus Handling
  • In demo, ensure that "Action on Bottom" is unchecked and disabled when "multiline" is unchecked
  • End-to-end usage example in README (instantiation, using it in response to an event)
  • Start-aligned snackbars (left for LTR, right for RTL)
  • Add dismissOnAction option, which defaults to true. When true, snackbar dismisses as soon as a user interacts with its action button (see Implement Snackbar Component #28).
  • Address Action label misaligned in RTL Snackbar #564

Copied from google/material-design-lite#4490

@abraham
Copy link

abraham commented Mar 4, 2017

It doesn't look like left-aligned for tablet/desktop is supported or on the todo list. Is that planned?

@Garbee
Copy link
Contributor

Garbee commented Mar 4, 2017

Left-aligned is new to the spec. A new issue should be made to track adding it as a modifier.

@traviskaufman
Copy link
Contributor Author

THanks @abraham and @Garbee. We actually think it makes the most sense to roll this issue into the TODO list here. Closing #382 and putting as an item.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants