Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mdc-switch to new version in line with Material guidelines #2825

Closed
6 tasks
lynnmercier opened this issue May 25, 2018 · 0 comments
Closed
6 tasks

Update mdc-switch to new version in line with Material guidelines #2825

lynnmercier opened this issue May 25, 2018 · 0 comments
Assignees
Labels

Comments

@lynnmercier
Copy link
Contributor

  • new HTML structure, with the thumb and track as sibling elements
  • HTML structure should also have the input element within the thumb, so that focus is within the element with the ripple
  • new JavaScript to listen to the input element, and apply parent CSS classes
  • baseline CSS, which styles the sub-elements based off the parent CSS classes
  • new Sass mixins to cover customizing the color of the thumb and track, in both the toggled on and toggled off state
  • baseline CSS should call these color Sass mixins, and apply color from mdc-theme

We will defer on the disabled state customization, and opacity customization, until a later issue/PR (see #2762 )

@rlfriedman rlfriedman self-assigned this May 25, 2018
rlfriedman added a commit that referenced this issue Jul 27, 2018
BREAKING CHANGE: MDC Switch DOM structure and Sass APIs have changed, and JavaScript APIs have been added. See the documentation for more information.

Fixes #2825
@jamesmfriedman jamesmfriedman mentioned this issue Jul 30, 2018
48 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants