fix(icon-button): update event handling to new standard #3165

moog16 · 2018-07-21T00:30:23Z

packages/mdc-icon-button/foundation.js

@@ -61,18 +61,10 @@ class MDCIconButtonToggleFoundation extends MDCFoundation {



bonniezhou · 2018-07-23T16:39:31Z

test/unit/mdc-icon-button/foundation.test.js

+  const {foundation, mockAdapter} = setupTest();
+  foundation.init();
+  foundation.handleClick();
+  td.verify(mockAdapter.setAttr('aria-pressed', 'true'), {times: 1});


I think this should verify that foundation.toggle() was called. The aria-pressed is verified in another test.

mdc-web-bot · 2018-07-24T22:12:25Z

🤖 Beep boop!

Screenshot test report

Commit 3e9b8d0 vs. master:

https://storage.googleapis.com/mdc-web-screenshot-tests/travis/2018/07/24/22_11_36_655/report/report.html

No diffs! 💯🎉

bonniezhou

Also remove registerInteractionHandler/deregisterInteractionHandler from adapter.js. Otherwise LGTM!

mdc-web-bot · 2018-07-25T01:04:16Z

🤖 Beep boop!

Screenshot test report

Commit 6cc8985 vs. master:

https://storage.googleapis.com/mdc-web-screenshot-tests/travis/2018/07/25/01_03_37_612/report/report.html

No diffs! 💯🎉

mdc-web-bot · 2018-07-25T16:49:31Z

🤖 Beep boop!

Screenshot test report

Commit c36f23a vs. master:

https://storage.googleapis.com/mdc-web-screenshot-tests/travis/2018/07/25/16_48_55_132/report/report.html

No diffs! 💯🎉

mdc-web-bot · 2018-07-25T17:00:45Z

🤖 Beep boop!

Screenshot test report

Commit 12ed874 vs. master:

https://storage.googleapis.com/mdc-web-screenshot-tests/travis/2018/07/25/17_00_08_704/report/report.html

No diffs! 💯🎉

…aterial-components/material-components-web into fix/icon-button/event-handler-standard

mdc-web-bot · 2018-07-25T20:26:48Z

🤖 Beep boop!

Screenshot test report

Commit ad47552 vs. master:

https://storage.googleapis.com/mdc-web-screenshot-tests/travis/2018/07/25/20_25_47_109/report/report.html

No diffs! 💯🎉

kfranqueiro

[de]registerInteractionHandler are still in the readme and should be removed

kfranqueiro · 2018-07-25T21:02:14Z

test/unit/mdc-icon-button/mdc-icon-button-toggle.test.js

+  td.verify(component.foundation_.handleClick(), {times: 1});
+});
+
+test('keydown handler is removed from the root element on destroy', () => {


keydown -> click

mdc-web-bot · 2018-07-25T21:04:07Z

🤖 Beep boop!

Screenshot test report

Commit 6f13d36 vs. master:

https://storage.googleapis.com/mdc-web-screenshot-tests/travis/2018/07/25/21_03_31_999/report/report.html

No diffs! 💯🎉

mdc-web-bot · 2018-07-25T21:12:55Z

🤖 Beep boop!

Screenshot test report

Commit 4facd12 vs. master:

https://storage.googleapis.com/mdc-web-screenshot-tests/travis/2018/07/25/21_12_10_615/report/report.html

No diffs! 💯🎉

mdc-web-bot · 2018-07-25T21:31:44Z

🤖 Beep boop!

Screenshot test report

Commit c1c1d38 vs. master:

https://storage.googleapis.com/mdc-web-screenshot-tests/travis/2018/07/25/21_30_55_257/report/report.html

No diffs! 💯🎉

mdc-web-bot · 2018-07-25T22:47:39Z

All 128 screenshot tests passed for commit c2e55bf vs. master! 💯🎉

…aterial-components/material-components-web into fix/icon-button/event-handler-standard

codecov-io · 2018-07-25T23:07:03Z

Codecov Report

Merging #3165 into master will decrease coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #3165      +/-   ##
==========================================
- Coverage   98.12%   98.12%   -0.01%     
==========================================
  Files         101      101              
  Lines        4426     4421       -5     
  Branches      585      585              
==========================================
- Hits         4343     4338       -5     
  Misses         83       83

Impacted Files	Coverage Δ
packages/mdc-icon-button/index.js	`100% <100%> (ø)`	⬆️
packages/mdc-icon-button/foundation.js	`95.74% <100%> (-0.56%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 547a980...9079594. Read the comment docs.

mdc-web-bot · 2018-07-25T23:20:46Z

All 128 screenshot tests passed for commit 6e8fd5d vs. master! 💯🎉

mdc-web-bot · 2018-07-25T23:36:24Z

All 128 screenshot tests passed for commit f937f13 vs. master! 💯🎉

mdc-web-bot · 2018-07-25T23:50:52Z

All 128 screenshot tests passed for commit a395dd6 vs. master! 💯🎉

mdc-web-bot · 2018-07-26T00:45:03Z

All 128 screenshot tests passed for commit a1ff5ac vs. master! 💯🎉

mdc-web-bot · 2018-07-26T03:42:59Z

All 128 screenshot tests passed for commit 44d35e7 vs. master! 💯🎉

….com:material-components/material-components-web into fix/icon-button/event-handler-standard

mdc-web-bot · 2018-07-26T05:11:27Z

All 128 screenshot tests passed for commit db77f72 vs. master! 💯🎉

mdc-web-bot · 2018-07-26T18:51:30Z

All 128 screenshot tests passed for commit 9079594 vs. master! 💯🎉

WIP: icon button event standardization

50e846b

bonniezhou suggested changes Jul 23, 2018

View reviewed changes

bonniezhou self-assigned this Jul 23, 2018

Matt Goo added 2 commits July 24, 2018 14:48

Merge branch 'master' into fix/icon-button/event-handler-standard

4c0ebca

fix: remove from defualt adapter

3e9b8d0

bonniezhou approved these changes Jul 24, 2018

View reviewed changes

WIP: lint

6cc8985

Matt Goo added 2 commits July 25, 2018 09:43

fix: test

c36f23a

Merge branch 'master' into fix/icon-button/event-handler-standard

12ed874

Matt Goo added 2 commits July 25, 2018 10:42

fix: IE11 test

597a024

Merge branch 'fix/icon-button/event-handler-standard' of github.com:m…

ad47552

…aterial-components/material-components-web into fix/icon-button/event-handler-standard

kfranqueiro suggested changes Jul 25, 2018

View reviewed changes

WIP: readme update!

6f13d36

kfranqueiro reviewed Jul 25, 2018

View reviewed changes

WIP: test

4facd12

Merge branch 'master' into fix/icon-button/event-handler-standard

c1c1d38

Matt Goo added 3 commits July 25, 2018 15:24

WIP: test

53b05ce

Update mdc-icon-button-toggle.test.js

09ebd96

Merge branch 'master' into fix/icon-button/event-handler-standard

c2e55bf

Matt Goo added 2 commits July 25, 2018 16:01

WIP: icon button event standardization

741a23a

fix: remove from defualt adapter

30f73ff

Matt Goo added 2 commits July 25, 2018 16:01

Merge branch 'fix/icon-button/event-handler-standard' of github.com:m…

88c9fb1

…aterial-components/material-components-web into fix/icon-button/event-handler-standard

WIP: test

6e8fd5d

Matt Goo added 2 commits July 25, 2018 16:24

WIP: test

f937f13

Merge branch 'master' into fix/icon-button/event-handler-standard

a395dd6

WIP: test

a1ff5ac

Matt Goo added 2 commits July 25, 2018 20:37

WIP: Test:w

44d35e7

Merge branch 'master' into fix/icon-button/event-handler-standard

dc9bbe9

Matt Goo added 7 commits July 25, 2018 20:53

WIP: TEST

7b25adb

Met pushrge branch 'fix/icon-button/event-handler-standard' of github…

71cb8c4

….com:material-components/material-components-web into fix/icon-button/event-handler-standard

WIP: test

600a858

WIP: test

96dc46c

WIP: ie11 windows 10

9271bc6

WIP: test

44d5d85

Merge branch 'master' into fix/icon-button/event-handler-standard

db77f72

moog16 mentioned this pull request Jul 26, 2018

fix(infrastructure): update saucelabs windows 8 to windows 10 IE11 browser #3234

Merged

Merge branch 'master' into fix/icon-button/event-handler-standard

9079594

kfranqueiro approved these changes Jul 26, 2018

View reviewed changes

moog16 merged commit 531867e into master Jul 26, 2018

moog16 deleted the fix/icon-button/event-handler-standard branch July 26, 2018 22:06

jamesmfriedman mentioned this pull request Jul 30, 2018

MDC 38/39 rmwc/rmwc#281

Closed

48 tasks

trimox mentioned this pull request Jul 30, 2018

Update to material-components-web v0.38.0 trimox/angular-mdc-web#1162

Closed

moog16 mentioned this pull request Aug 1, 2018

Remove unused adapter methods from icon-button #3277

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(icon-button): update event handling to new standard #3165

fix(icon-button): update event handling to new standard #3165

moog16 commented Jul 21, 2018 •

edited by kfranqueiro

Loading

This comment was marked as resolved.

bonniezhou Jul 23, 2018

mdc-web-bot commented Jul 24, 2018

bonniezhou left a comment

mdc-web-bot commented Jul 25, 2018

mdc-web-bot commented Jul 25, 2018

mdc-web-bot commented Jul 25, 2018

mdc-web-bot commented Jul 25, 2018

kfranqueiro left a comment

kfranqueiro Jul 25, 2018

mdc-web-bot commented Jul 25, 2018

mdc-web-bot commented Jul 25, 2018

mdc-web-bot commented Jul 25, 2018

mdc-web-bot commented Jul 25, 2018

codecov-io commented Jul 25, 2018 •

edited

Loading

mdc-web-bot commented Jul 25, 2018

mdc-web-bot commented Jul 25, 2018

mdc-web-bot commented Jul 25, 2018

mdc-web-bot commented Jul 26, 2018

mdc-web-bot commented Jul 26, 2018

mdc-web-bot commented Jul 26, 2018

mdc-web-bot commented Jul 26, 2018

		@@ -61,18 +61,10 @@ class MDCIconButtonToggleFoundation extends MDCFoundation {

fix(icon-button): update event handling to new standard #3165

fix(icon-button): update event handling to new standard #3165

Conversation

moog16 commented Jul 21, 2018 • edited by kfranqueiro Loading

This comment was marked as resolved.

bonniezhou Jul 23, 2018

Choose a reason for hiding this comment

mdc-web-bot commented Jul 24, 2018

Screenshot test report

No diffs! 💯🎉

bonniezhou left a comment

Choose a reason for hiding this comment

mdc-web-bot commented Jul 25, 2018

Screenshot test report

No diffs! 💯🎉

mdc-web-bot commented Jul 25, 2018

Screenshot test report

No diffs! 💯🎉

mdc-web-bot commented Jul 25, 2018

Screenshot test report

No diffs! 💯🎉

mdc-web-bot commented Jul 25, 2018

Screenshot test report

No diffs! 💯🎉

kfranqueiro left a comment

Choose a reason for hiding this comment

kfranqueiro Jul 25, 2018

Choose a reason for hiding this comment

mdc-web-bot commented Jul 25, 2018

Screenshot test report

No diffs! 💯🎉

mdc-web-bot commented Jul 25, 2018

Screenshot test report

No diffs! 💯🎉

mdc-web-bot commented Jul 25, 2018

Screenshot test report

No diffs! 💯🎉

mdc-web-bot commented Jul 25, 2018

codecov-io commented Jul 25, 2018 • edited Loading

Codecov Report

mdc-web-bot commented Jul 25, 2018

mdc-web-bot commented Jul 25, 2018

mdc-web-bot commented Jul 25, 2018

mdc-web-bot commented Jul 26, 2018

mdc-web-bot commented Jul 26, 2018

mdc-web-bot commented Jul 26, 2018

mdc-web-bot commented Jul 26, 2018

moog16 commented Jul 21, 2018 •

edited by kfranqueiro

Loading

codecov-io commented Jul 25, 2018 •

edited

Loading