Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tab-indicator): Remove transitionend event handling #3337

Merged
merged 4 commits into from
Aug 14, 2018

Conversation

kfranqueiro
Copy link
Contributor

@kfranqueiro kfranqueiro commented Aug 13, 2018

This reworks Tab Indicator's transition styles and logic such that we don't need to handle transitionend whatsoever. This allows pulling event handling out of its foundation/adapter outright, without even needing to hook anything up in the component.

Refs #2813

BREAKING CHANGE: Removes handleTransitionEnd foundation API. Removes [de]registerEventHandler adapter APIs.

@patrickrodee patrickrodee self-assigned this Aug 13, 2018
@mdc-web-bot
Copy link
Collaborator

All 337 screenshot tests passed for commit d641cea vs. master! 💯🎉

@codecov-io
Copy link

codecov-io commented Aug 13, 2018

Codecov Report

Merging #3337 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3337      +/-   ##
==========================================
- Coverage   98.14%   98.13%   -0.01%     
==========================================
  Files         123      123              
  Lines        5217     5194      -23     
  Branches      638      638              
==========================================
- Hits         5120     5097      -23     
  Misses         97       97
Impacted Files Coverage Δ
packages/mdc-tab-indicator/foundation.js 100% <ø> (ø) ⬆️
packages/mdc-tab-indicator/constants.js 100% <ø> (ø) ⬆️
packages/mdc-tab-indicator/fading-foundation.js 100% <ø> (ø) ⬆️
packages/mdc-tab-indicator/index.js 100% <ø> (ø) ⬆️
packages/mdc-tab-indicator/sliding-foundation.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1245573...e17a889. Read the comment docs.

@mdc-web-bot
Copy link
Collaborator

All 349 screenshot tests passed for commit e17a889 vs. master! 💯🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants