Skip to content
This repository has been archived by the owner on Oct 7, 2020. It is now read-only.

feat(tab-indicator): Remove transitionend event handling #1243

Merged
merged 2 commits into from
Aug 26, 2018

Conversation

trimox
Copy link
Owner

@trimox trimox commented Aug 23, 2018

This reworks Tab Indicator transition styles and logic such that we don't need to handle transitionend whatsoever. This allows pulling event handling out of its foundation/adapter outright, without even needing to hook anything up in the component.

reference: material-components/material-components-web#3337

@trimox trimox added the new-mdc-feature Feature incorporated from material-components-web label Aug 23, 2018
@trimox trimox added this to the v0.39.0 milestone Aug 23, 2018
@codecov
Copy link

codecov bot commented Aug 23, 2018

Codecov Report

Merging #1243 into master will increase coverage by 0.08%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1243      +/-   ##
==========================================
+ Coverage   93.25%   93.33%   +0.08%     
==========================================
  Files         173      173              
  Lines        6628     6620       -8     
  Branches      970      968       -2     
==========================================
- Hits         6181     6179       -2     
+ Misses        447      441       -6
Impacted Files Coverage Δ
packages/tab-indicator/tab-indicator.ts 85.36% <100%> (+5.36%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f2f912...79e0ab3. Read the comment docs.

@trimox trimox merged commit 5c49274 into master Aug 26, 2018
@trimox trimox deleted the feat/tab-indicator-transition-end branch August 26, 2018 15:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
new-mdc-feature Feature incorporated from material-components-web
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant