fix(drawer): Remove list item children to be included in click target. #3480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All 353 screenshot tests passed for commit 809750e vs. |
packages/mdc-drawer/common.scss
Outdated
| @@ -89,6 +89,12 @@ | |||
| .mdc-list-divider { | |||
| margin: 3px 0 4px 0; | |||
| } | |||
|
|
|||
| // Prevents list item children to be included in click target. | |||
There was a problem hiding this comment.
Prevents list item children from being included in the click target.
|
All 353 screenshot tests passed for commit 32cf901 vs. |
|
All 357 screenshot tests passed for commit 1772a34 vs. |
|
All 357 screenshot tests passed for commit c2027a9 vs. |
adrianschmidt
pushed a commit
to Lundalogik/material-components-web
that referenced
this pull request
Sep 25, 2018
material-components#3480) (cherry picked from commit cc3ae2f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #3460 adds additional wrapper element to text label inside list item it might be included as click target. In this change, drawer removes the pointer events from list item children including
__text&__graphicso click event always originates fromlist-iteminstead of its children.The long-term solution would be to have a custom event for MDC List that drawer & menu can listen to.