Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(drawer): Remove list item children to be included in click target. #3480

Merged
merged 8 commits into from
Aug 31, 2018
Merged

fix(drawer): Remove list item children to be included in click target. #3480

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
0eea832
fix(list): Set all other list item child elements pointer event to none
abhiomkar Aug 30, 2018
809750e
fix(drawer): remove pointer events from list item children for right …
abhiomkar Aug 30, 2018
8e56508
fix(drawer): Changes in code comments
abhiomkar Aug 30, 2018
32cf901
Merge remote-tracking branch 'origin/master' into fix/drawer/click_ta…
abhiomkar Aug 30, 2018
1772a34
Merge branch 'master' into fix/drawer/click_target
williamernest Aug 30, 2018
2e09aaf
fix(drawer): dummy commit
abhiomkar Aug 31, 2018
7d88071
Merge remote-tracking branch 'origin/fix/drawer/click_target' into fi…
abhiomkar Aug 31, 2018
c2027a9
Merge branch 'master' into fix/drawer/click_target
williamernest Aug 31, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions demos/drawer/dismissible-drawer.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,6 +220,7 @@ <h1 class="mdc-typography--headline4">Dismissible Drawer</h1>
mainEl.querySelector('input').focus();
});
});

</script>
</body>
</html>
6 changes: 6 additions & 0 deletions packages/mdc-drawer/common.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,12 @@
.mdc-list-divider {
margin: 3px 0 4px 0;
}

// Prevents list item children from being included in the click target.
.mdc-list-item__text,
.mdc-list-item__graphic {
pointer-events: none;
}
}

.mdc-drawer--open {
Expand Down
2 changes: 0 additions & 2 deletions packages/mdc-list/mdc-list.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,8 +103,6 @@

.mdc-list-item__text {
@include mdc-typography-overflow-ellipsis;

pointer-events: none;
}

$mdc-list-item-primary-text-baseline-height_: 32px;
Expand Down