Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate List component with Dialog in docs and screenshot tests #3592

Closed
kfranqueiro opened this issue Sep 20, 2018 · 0 comments
Closed

Integrate List component with Dialog in docs and screenshot tests #3592

kfranqueiro opened this issue Sep 20, 2018 · 0 comments
Assignees
Labels
Milestone

Comments

@kfranqueiro
Copy link
Contributor

Now that #3546 is in, the dialog screenshot test pages should instantiate MDC List when applicable, and documentation should be augmented to include an example of this.

I've already started working on this, and it additionally looks like we'll probably want to add keydown enter/space handling for data-mdc-dialog-action to cover all scenarios. Otherwise currently you need to use a div + a elements (plus fix a bug in List, which I'll PR separately) in order to capture space/enter on the list in the Simple Dialog variant (by making the list items fire clicks), which feels a little awkward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant