Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dialog): Integrate with MDC List; add keyboard action handling #3594

Merged
merged 3 commits into from Sep 21, 2018

Conversation

kfranqueiro
Copy link
Contributor

Fixes #3592.

Also adds a couple of tests for autoStackButtons that I apparently missed before.

Copy link
Contributor

@williamernest williamernest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@codecov-io
Copy link

codecov-io commented Sep 20, 2018

Codecov Report

Merging #3594 into master will increase coverage by 0.07%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3594      +/-   ##
==========================================
+ Coverage   98.35%   98.43%   +0.07%     
==========================================
  Files         120      120              
  Lines        5176     5182       +6     
  Branches      643      645       +2     
==========================================
+ Hits         5091     5101      +10     
+ Misses         85       81       -4
Impacted Files Coverage Δ
packages/mdc-dialog/index.js 100% <100%> (+4.39%) ⬆️
packages/mdc-dialog/foundation.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b556724...7c6a110. Read the comment docs.

@kfranqueiro kfranqueiro merged commit 7b6d86b into master Sep 21, 2018
@kfranqueiro kfranqueiro deleted the feat/dialog-list-integration branch September 21, 2018 00:22
@jamesmfriedman jamesmfriedman mentioned this pull request Sep 26, 2018
49 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants