Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Snackbar action handler text not appearing #3981

Closed
ganeshaprabhu opened this issue Oct 23, 2018 · 3 comments · Fixed by #4166
Closed

Snackbar action handler text not appearing #3981

ganeshaprabhu opened this issue Oct 23, 2018 · 3 comments · Fixed by #4166
Assignees
@acdvorak
Labels
bug
Milestone
v0.43.0

Comments

@ganeshaprabhu
Copy link

ganeshaprabhu commented Oct 23, 2018 •
edited by acdvorak
Loading

What MDC Web Version are you using?

0.35

What browser(s) is this bug affecting?

  • Chrome 69.0.3497
  • IE 11
  • Firefox

What OS are you using?

  • Windows 10
  • Windows 8

What are the steps to reproduce the bug?

  1. Go to the snackbar demo page
  2. Click "show snackbar" button and click action handler text
  3. Click "show start aligned" button and click action handler text
  4. Again click the "show snackbar" button

What is the expected behavior?

The action handler text should be visible near the snackbar.

What is the actual behavior?

Snackbar behavior is not correct on consecutive instances.

The action handler text is disappeared and there is no way to close the snackbar before it automatically fades away.
@acdvorak acdvorak added this to the R21 (v0.42.0) milestone Oct 25, 2018
@acdvorak
Copy link
Contributor

Thanks for filing this issue!

I was able to reproduce it, but not reliably. Is it timing-specific?

Could you possibly capture a video of the steps you took to reproduce the bug?

Here's a screenshot:

image

@acdvorak acdvorak self-assigned this Oct 25, 2018
@acdvorak acdvorak added the bug label Oct 25, 2018
@ghost
Copy link

ghost commented Nov 4, 2018

Got into the same problem, here's the video: link.

@acdvorak
Copy link
Contributor

acdvorak commented Nov 5, 2018

Thanks for the video capture, @vuchastyi!

Converted to animated GIF:

snackbar_bug

@acdvorak acdvorak mentioned this issue Nov 7, 2018
Closed
6 tasks
@kfranqueiro kfranqueiro modified the milestones: R21 (v0.42.0), v0.43.0 Nov 30, 2018
@acdvorak acdvorak mentioned this issue Dec 11, 2018
Merged
acdvorak added a commit that referenced this issue Dec 13, 2018
@acdvorak
feat(snackbar): Update to match latest design guidelines (#4166)
33d30e6 
### Issues fixed

* Fixes #4005 (via new `mdc-snackbar-viewport-margin()` mixin)
* Fixes #3981
* Fixes #2916 (via new `MDCSnackbar:closing` and `MDCSnackbar:closed` events)
* Fixes #2628
* Fixes #1466 (via new `close()` method)
* Fixes #1398
* Fixes #1258
* Fixes #11 (the label now expands indefinitely to fit the text)
* Refs #2813

### Screenshots

![Baseline without action button](https://user-images.githubusercontent.com/409245/49956261-a080ca80-feb9-11e8-8287-b7e805344115.png)

![Baseline with action button](https://user-images.githubusercontent.com/409245/49956109-4a138c00-feb9-11e8-9213-3241fa86a1b8.png)

![Stacked layout](https://user-images.githubusercontent.com/409245/49956173-6a434b00-feb9-11e8-8a03-2e58ccc8f763.png)

BREAKING CHANGE: Snackbar's DOM and APIs have changed to match the latest design guidelines. See the Snackbar documentation for more information.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@acdvorak acdvorak

Labels
bug
Projects
None yet
Milestone
v0.43.0
Development

Successfully merging a pull request may close this issue.

feat(snackbar): Update to match latest design guidelines material-components/material-components-web
3 participants
@kfranqueiro @acdvorak @ganeshaprabhu