Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(text-field): Add focus API to component #4020

Merged
merged 1 commit into from
Oct 30, 2018
Merged

feat(text-field): Add focus API to component #4020

merged 1 commit into from
Oct 30, 2018

Conversation

kfranqueiro
Copy link
Contributor

Fixes #4009.

@codecov-io
Copy link

codecov-io commented Oct 30, 2018 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@2645aa4). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #4020   +/-   ##
=========================================
  Coverage          ?   98.67%           
=========================================
  Files             ?      126           
  Lines             ?     5596           
  Branches          ?      746           
=========================================
  Hits              ?     5522           
  Misses            ?       74           
  Partials          ?        0
Impacted Files Coverage Δ
packages/mdc-textfield/index.js 93.75% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2645aa4...d88484c. Read the comment docs.

williamernest
williamernest approved these changes Oct 30, 2018
View reviewed changes
Copy link
Contributor

@williamernest williamernest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mdc-web-bot
Copy link
Collaborator

All 652 screenshot tests passed for commit d88484c vs. master! 💯🎉

@kfranqueiro kfranqueiro merged commit edcb939 into master Oct 30, 2018
@kfranqueiro kfranqueiro deleted the feat/text-field/focus branch October 30, 2018 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@williamernest williamernest williamernest approved these changes

Assignees

@williamernest williamernest

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kfranqueiro @codecov-io @mdc-web-bot @williamernest @googlebot