fix(top-app-bar): Move scroll target initialization; improve test #4106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4106 +/- ##
=======================================
Coverage 98.67% 98.67%
=======================================
Files 126 126
Lines 5603 5603
Branches 747 747
=======================================
Hits 5529 5529
Misses 74 74
Continue to review full report at Codecov.
|
abhiomkar
approved these changes
Nov 21, 2018
| @@ -292,8 +291,8 @@ test('adapter#getViewportScrollY returns scroll distance', () => { | |||
|
|
|||
| test('adapter#getViewportScrollY returns scroll distance when scrollTarget_ is not window', () => { | |||
| const {component, fixture} = setupTest(); | |||
| const content = fixture.querySelector('.content'); | |||
| component.scrollTarget_ = content; | |||
| const content = {addEventListener: () => {}, scrollTop: 20}; | |||
| @@ -292,8 +291,8 @@ test('adapter#getViewportScrollY returns scroll distance', () => { | |||
|
|
|||
| test('adapter#getViewportScrollY returns scroll distance when scrollTarget_ is not window', () => { | |||
| const {component, fixture} = setupTest(); | |||
There was a problem hiding this comment.
Remove unused variable fixture.
|
All 663 screenshot tests passed for commit abe86fc vs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves the test failure discovered in #4046.
The
getViewportScrollYadapter unit test was coincidentally passing because the page's scroll offset and the scroll offset of the content element were typically both 0. This only ended up not being the case when I tried running our unit tests via headless Firefox on Travis.The test as written actually should never have passed, because
getDefaultFoundationin the Top App Bar component had the side effect of resetting the scroll target, effectively undoing the test's setup.This fixes the component to initialize the scroll target in
initializerather thangetDefaultFoundation, and fixes the test to use a mock object to guarantee a distinguishable expected value.