Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package mdc-drawer missing export 'util' #422

Closed
pgbross opened this issue Mar 22, 2017 · 0 comments
Closed

Package mdc-drawer missing export 'util' #422

pgbross opened this issue Mar 22, 2017 · 0 comments
Assignees

Comments

@pgbross
Copy link
Contributor

pgbross commented Mar 22, 2017

What MDC-Web Version are you using?

0.7.0

What browser(s) is this bug affecting?

Version 58.0.3029.19 beta (64-bit)

What OS are you using?

Fedora 25 (Linux p5q 4.9.13-201.fc25.x86_64)

What are the steps to reproduce the bug?

  1. Write a framework example, such as vue/src/v-mdc-drawer/TemporaryDrawer.vue
  2. import { MDCTemporaryDrawerFoundation, util } from '@material/drawer';
  3. Use the component and observe that util is undefined.

What is the expected behavior?

The mdc-drawer util methods should be available for users of the @material/drawer package (from the dist/mdc.drawer.js code) without having to import util from the node_modules folder separately. Note this change is also needed when no module system is used under the global mdc namespace where there is no workaround.

What is the actual behavior?

The util methods are unavailable and need to be imported separately when writing, say, a framework integration example.

Any other information you believe would be useful?

The mdc-dialog package does this correctly by including:

import * as util from './util';
export{util};

in its index.js file, and the same should be done in mdc-drawer/index.js.

pgbross added a commit to pgbross/material-components-web that referenced this issue Mar 22, 2017
@amsheehan amsheehan self-assigned this Mar 23, 2017
pgbross added a commit to pgbross/material-components-web that referenced this issue Mar 23, 2017
traviskaufman pushed a commit that referenced this issue Mar 29, 2017
pgbross pushed a commit to pgbross/material-components-web that referenced this issue Mar 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants