fix(top-app-bar): Move comment line to appropriate section #4610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhiomkar
reviewed
Apr 18, 2019
| @@ -103,32 +132,3 @@ | |||
| } | |||
| } | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
It was intentional to keep all private mixins at the bottom of the file. Any reason for change of its location?
There was a problem hiding this comment.
In that case, doesn't it make sense to move // private comment lines above mdc-top-app-bar-mobile-breakpoint_ mixin? This'll avoid touching git history.
There was a problem hiding this comment.
Yea, that would be better, I'll adjust it.
|
It's in the public section. I moved it to the private section. |
abhiomkar
reviewed
Apr 22, 2019
|
@abhiomkar There's a private mixin in the public section. |
Move MDCTopAppBar mixin that is private from public to private section fixes #4609
|
@abhiomkar Okay, I believe I adjusted it correctly. |
abhiomkar
changed the title
abhiomkar
approved these changes
May 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move MDCTopAppBar mixin that is private from public to private section
fixes #4609