-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(top-app-bar): Move comment line to appropriate section #4610
fix(top-app-bar): Move comment line to appropriate section #4610
Conversation
@@ -103,32 +132,3 @@ | |||
} | |||
} | |||
} | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was intentional to keep all private mixins at the bottom of the file. Any reason for change of its location?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In that case, doesn't it make sense to move // private
comment lines above mdc-top-app-bar-mobile-breakpoint_
mixin? This'll avoid touching git history.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea, that would be better, I'll adjust it.
It's in the public section. I moved it to the private section. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is intentional to keep private mixins at the bottom of sass file.
@abhiomkar There's a private mixin in the public section. |
Move MDCTopAppBar mixin that is private from public to private section fixes #4609
@abhiomkar Okay, I believe I adjusted it correctly. |
Move MDCTopAppBar mixin that is private from public to private section
fixes #4609