Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(top-app-bar): Move comment line to appropriate section #4610

Merged
merged 4 commits into from
May 3, 2019
Merged

fix(top-app-bar): Move comment line to appropriate section #4610

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b864fbf
fix: Fix MDCTopAppBar mixin to private
ALMaclaine Apr 23, 2019
189ee04
Merge branch 'master' into fix/MDCTopAppBarMovePrivateMixinToPrivateS…
abhiomkar May 3, 2019
d937ca8
Merge branch 'master' into fix/MDCTopAppBarMovePrivateMixinToPrivateS…
abhiomkar May 3, 2019
eb5839b
Merge branch 'master' into fix/MDCTopAppBarMovePrivateMixinToPrivateS…
abhiomkar May 3, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions packages/mdc-top-app-bar/_mixins.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,10 @@
}
}

//
// Private
//

@mixin mdc-top-app-bar-mobile-breakpoint_($mobile-breakpoint: $mdc-top-app-bar-mobile-breakpoint) {
@media (max-width: $mobile-breakpoint) {
.mdc-top-app-bar__row {
Expand Down Expand Up @@ -104,10 +108,6 @@
}
}

Copy link
Contributor

@abhiomkar abhiomkar Apr 18, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was intentional to keep all private mixins at the bottom of the file. Any reason for change of its location?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In that case, doesn't it make sense to move // private comment lines above mdc-top-app-bar-mobile-breakpoint_ mixin? This'll avoid touching git history.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, that would be better, I'll adjust it.

//
// Private
//

// Applies styles to the different types of icons that can exist in top-app-bars.
// Both .mdc-top-app-bar__icon and .mdc-top-app-bar__navigation-icon share all styles except for
// horizontal padding.
Expand Down