Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MDCTab] Ripple is not working #6847

Closed
rubysamurai opened this issue Feb 15, 2021 · 4 comments · Fixed by #6858
Closed

[MDCTab] Ripple is not working #6847

rubysamurai opened this issue Feb 15, 2021 · 4 comments · Fixed by #6858
Assignees
@EstebanG23
Labels
bug

Comments

@rubysamurai
Copy link

Bug report

Upon upgrading from @material/tab v9.0.0 to v10.0.0 ripple effect for the tab is not working.

Actual behavior

MDCTab v10.0.0 codepen

v10

Expected behavior

MDCTab v9.0.0 codepen

v9

Your Environment:

Software Version(s)
MDC Web 10.0.0
Browser Chrome 88
Operating System Ubuntu 20.04
@allan-chen
Copy link
Contributor

allan-chen commented Feb 17, 2021 •
edited
Loading

fb79393 may have caused this - @EstebanG23 could you take a look?

@allan-chen allan-chen linked a pull request Feb 18, 2021 that will close this issue
fix(tab): Update ripple adapter to reflect sass ripple-target. #6858
Merged
MaximBalaganskiy added a commit to aurelia-ui-toolkits/aurelia-mdc-web that referenced this issue Feb 18, 2021
@MaximBalaganskiy
fix(tab-bar): set correct ripple target
bd0fe37 
See material-components/material-components-web#6847
@MaximBalaganskiy
Copy link
Contributor

MaximBalaganskiy commented Feb 23, 2021 •
edited
Loading

Please reopen. This sets overflow: hidden on the tab which hides a sliding out tab indicator.

@allan-chen
Copy link
Contributor

Hey Maxim, AFAIK overflow is only set on mdc-tab__ripple subelement. On the codepen here with the canary release it seems to work properly: https://codepen.io/allanchenmdc/pen/KKNyKpK

Let me know if you can reproduce with a codepen. Thanks!

@MaximBalaganskiy
Copy link
Contributor

Sorry, my fault. Should not have added the surface class in the tab

MaximBalaganskiy added a commit to aurelia-ui-toolkits/aurelia-mdc-web that referenced this issue Feb 23, 2021
@MaximBalaganskiy
fix(tab-bar): set correct ripple target
b70a26f 
See material-components/material-components-web#6847
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@EstebanG23 EstebanG23

Labels
bug
Projects
None yet
Milestone
No milestone
4 participants
@rubysamurai @MaximBalaganskiy @allan-chen @EstebanG23