Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate adding focus trapping to all relevant components #70

Closed
2 tasks
traviskaufman opened this issue Dec 9, 2016 · 3 comments
Closed
2 tasks

Comments

@traviskaufman
Copy link
Contributor

traviskaufman commented Dec 9, 2016

Helpers package for reusable functions for dealing with UI interactions. For this particular issue, we are simply implementing focus trapping, but the package has the potential to facilitate more ui-related helper functions as well.

  • Create package
  • Refactor mdc-temporary-drawer to use package
@sgomes
Copy link
Contributor

sgomes commented Dec 19, 2016

As a note, we already have focus trapping implemented on the menu. We should refactor that code out into the mdc-ui-helpers package.

@Garbee
Copy link
Contributor

Garbee commented Apr 11, 2017

The dialog component could also be refactored to use this helper library. iirc it has/had some problems with focus trapping as well.

@lynnmercier lynnmercier changed the title Create mdc-ui-helpers lib for focus trapping Investigate adding focus trapping to all relevant components Jan 23, 2018
@kfranqueiro
Copy link
Contributor

MDC Web now relies upon the focus-trap third-party library for modal behavior within MDC Dialog and MDC Drawer. This is hooked up via an adapter and util API so that it can be replaced in other contexts if necessary.

MDC Menu's focus trapping logic is a bit more unique and does not reuse focus-trap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants