Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use passive event listeners for the ripple #629

Closed
sgomes opened this issue May 11, 2017 · 2 comments · Fixed by #649
Closed

Use passive event listeners for the ripple #629

sgomes opened this issue May 11, 2017 · 2 comments · Fixed by #649

Comments

@sgomes
Copy link
Contributor

sgomes commented May 11, 2017

There are going to be some new metrics in Lighthouse, one of which looks at whether touch event listeners are being marked as passive.

We currently use touch events in two places: drawers and the ripple. We already have passive event listeners for the drawer where supported, but the ripple doesn't do the same. As long as it doesn't cancel the events, it should be able to make use of passive as well.

Making sure we apply passive event listeners wherever possible would both ensure better performance in MDC-Web components, as well as higher Lighthouse scores for applications using it.

@traviskaufman
Copy link
Contributor

Great suggestion @sgomes! Adding "help wanted" to this as the work is straightforward:

@sgomes
Copy link
Contributor Author

sgomes commented May 30, 2017

Woohoo, thank you @trimox!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants