Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toolbar for Desktop should be 24px per guidelines #786

Closed
RhysyG opened this issue Jun 5, 2017 · 2 comments
Closed

Toolbar for Desktop should be 24px per guidelines #786

RhysyG opened this issue Jun 5, 2017 · 2 comments

Comments

@RhysyG
Copy link

RhysyG commented Jun 5, 2017

What MDC-Web Version are you using?

0.11.1

What browser(s) is this bug affecting?

Chrome

What OS are you using?

MacOS Sierra 10.12.5 (16F73)

What are the steps to reproduce the bug?

No step, just initial styles.

What is the expected behavior?

Padding left and right for DESKTOP should be 24px per Material Design Guidelines:
https://material.io/guidelines/layout/structure.html#structure-app-bar

What is the actual behavior?

Padding left and right is 28px.

Any other information you believe would be useful?

@amsheehan
Copy link
Contributor

Would you have the time to make a PR with these changes? I believe the change should be fairly simple:

  • Alter the base styles for mdc-toolbar__icon and the left-margin on mdc-toolbar__title to conform to the desktop styles in spec
  • Restore the values for those properties to what they currently are in the media query

@RhysyG
Copy link
Author

RhysyG commented Jun 6, 2017

Yeah sure thing. Wouldn't I need to:

Change variable $mdc-toolbar-padding to 20px 24px;
Which will change mdc-toolar__row padding.

Change mdc-toolbar__title to margin-left: 32px ?

Which will position title 72px from left on mobile and 80px left on desktop (presuming the icon only takes up 24px).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants