feat(fab): Add mdc-fab-accessible mixin #1238
Conversation
packages/mdc-fab/README.md
Outdated
|
|
||
| #### `mdc-fab-accessible($container-color)` | ||
|
|
||
| Changes the FAB's container color to the given color, and updates the FABs ink and ripple color to be meet |
There was a problem hiding this comment.
FABs -> FAB's; "to be meet" -> "to meet"
packages/mdc-fab/README.md
Outdated
| Changes the FAB's container color to the given color, and updates the FABs ink and ripple color to be meet | ||
| accessibility standards. | ||
|
|
||
| The following mixins are intended for advanced users. These mixins will override the color of the container, |
There was a problem hiding this comment.
Can we add a horizontal rule above this paragraph (--- should do it)? I'm concerned otherwise that this will look like it belongs to the preceding heading rather than as a foreword to the next ones.
packages/mdc-fab/_mixins.scss
Outdated
| @mixin mdc-fab-accessible($container-color) { | ||
| @include mdc-fab-container-color($container-color); | ||
| $light-or-dark: mdc-theme-light-or-dark($container-color); | ||
| @if ($light-or-dark == 'light') { |
There was a problem hiding this comment.
It might be helpful to have a comment here about how 'light' refers to the text color rather than the background color... I had to look it up to convince myself this code wasn't backwards.
packages/mdc-fab/_variables.scss
Outdated
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| $light-ripple-config: (base-color: white, opacity: .16); |
There was a problem hiding this comment.
Missing newline at end of file?
| @@ -14,6 +14,7 @@ | |||
|
|
|||
| @import "@material/theme/variables"; | |||
| @import "./mixins"; | |||
| @import "./variables"; | |||
There was a problem hiding this comment.
This isn't actually needed here, is it?
There was a problem hiding this comment.
oops, forgot to reference it. Updated now.
packages/mdc-fab/_variables.scss
Outdated
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| $light-ripple-config: (base-color: white, opacity: .16); |
There was a problem hiding this comment.
Are we thinking this variable might eventually live in another package?
There was a problem hiding this comment.
Probably some day, but we can refactor state stuff then.
No description provided.