refactor(button): Remove primary and accent modifier #1270
Conversation
yeelan0319
force-pushed
the
refactor/remove-theme-modifiers
branch
from
21abf2c
to
252cbc6
Compare
Codecov Report
@@ Coverage Diff @@
## master #1270 +/- ##
======================================
Coverage 99.9% 99.9%
======================================
Files 69 69
Lines 3307 3307
Branches 407 407
======================================
Hits 3304 3304
Misses 3 3Continue to review full report at Codecov.
|
packages/mdc-button/README.md
Outdated
| ``` | ||
| | Class | Description | | ||
| | --------------------- | ------------------------------------------------------- | | ||
| | `mdc-button` | A text button that is flush with the surface. | |
There was a problem hiding this comment.
Should this be documented as Mandatory and the others documented as Optional?
There was a problem hiding this comment.
That's a great question!
IMHO, the html structure have already demonstrated this point, so I might not feel confused. But it should be useful to someone new to this library, I will add it.
There was a problem hiding this comment.
The reason I mentioned both "Mandatory" and "Optional" is it would match the practice e.g. in the FAB docs: https://github.com/material-components/material-components-web/tree/master/packages/mdc-fab#css-classes
yeelan0319
force-pushed
the
refactor/remove-theme-modifiers
branch
3 times, most recently
from
f80c5b7
to
43e302d
Compare
BREAKING CHANGE: Remove support of `mdc-button--primary` and `mdc-button--accent` modifier classes. For custom and theme button implementation, use button mixins instead. See `demos.scss` for details.
yeelan0319
force-pushed
the
refactor/remove-theme-modifiers
branch
from
43e302d
to
dafad7c
Compare
BREAKING CHANGE: Remove support of
mdc-button--primaryandmdc-button--accentmodifier classes. For custom and theme button implementation, use button mixins instead. Seedemos.scssfor details.