Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(icon-toggle): Added support for SVG icons #1898

Closed
wants to merge 1 commit into from
Closed

feat(icon-toggle): Added support for SVG icons #1898

wants to merge 1 commit into from

Conversation

MichaelTamm
Copy link
Contributor

No description provided.

@codecov-io
Copy link

Codecov Report

Merging #1898 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1898      +/-   ##
==========================================
+ Coverage   99.43%   99.43%   +<.01%     
==========================================
  Files          84       84              
  Lines        3721     3728       +7     
  Branches      484      486       +2     
==========================================
+ Hits         3700     3707       +7     
  Misses         21       21
Impacted Files Coverage Δ
packages/mdc-icon-toggle/foundation.js 100% <100%> (ø) ⬆️
packages/mdc-icon-toggle/index.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 302349e...0d1b624. Read the comment docs.

@flundermicha
Copy link

Ping

1 similar comment
@MichaelTamm
Copy link
Contributor Author

Ping

@kfranqueiro
Copy link
Contributor

Sorry for letting this PR lapse for so long. This has now become obsoleted by the mdc-icon-button package (see #2748), which now has basic SVG support.

However, I think this also attempted to implement the ability to support different SVGs for on/off states, which Icon Button currently doesn't. This has been identified in #3107 with a proposed alternative approach to the component's DOM structure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants