Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

button/fab: Show active button press feedback on iOS #192

Merged
merged 2 commits into from Jan 19, 2017
Merged

button/fab: Show active button press feedback on iOS #192

merged 2 commits into from Jan 19, 2017

Conversation

traviskaufman
Copy link
Contributor

Resolves #110

Note: this PR should be rebased and merged rather than squashed and merged

sgomes
sgomes approved these changes Jan 19, 2017
View reviewed changes
Copy link
Contributor

@sgomes sgomes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@traviskaufman
fix(button): Show active button press feedback on iOS
ffebabd 
Adds rudimentary styling for `-webkit-tap-highlight-color` so that
feedback is given when a button is clicked on iOS.

Part of #110
@traviskaufman
fix(fab): Show active button press feedback on iOS
a4e86c0 
Adds rudimentary styling for `-webkit-tap-highlight-color` so that
feedback is given when a FAB is clicked on iOS.

Part of #110
@traviskaufman traviskaufman merged commit 8e7bc5f into master Jan 19, 2017
@traviskaufman traviskaufman deleted the fix/buttons-ios-active-state branch January 19, 2017 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgomes sgomes sgomes approved these changes

@amsheehan amsheehan Awaiting requested review from amsheehan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@traviskaufman @sgomes