chore(floating-label): separate label module from text-field #2237

moog16 · 2018-02-12T22:55:29Z

BREAKING CHANGE: must use .mdc-floating-label selector instead of .mdc-text-field__label

…ate with mdc-text-field

WIP- JS tests

…abel

moog16 · 2018-02-12T23:01:59Z

packages/mdc-floating-label/_mixins.scss


-@mixin mdc-text-field-label-float_($positionY, $positionX: 0%, $scale: .75) {
+@mixin mdc-floating-label-position_($positionY, $positionX: 0%, $scale: .75) {


maybe this should be mdc-floating-label-float-position? Is that clearer?

…t-field

…-components/material-components-web into chore/text-field/decouple-label

moog16 · 2018-02-12T23:34:13Z

packages/mdc-floating-label/_mixins.scss

+
+// Private
+
+@mixin mdc-floating-label-invalid-shake-keyframes_($modifier, $positionY, $positionX: 0%, $scale: .75) {


I think it might make more sense to make this public, and move the @includes to the text-field scss file, along with the variables. Reason being select might not have the same variants (box, outlined, outlined-dense, etc).

Want to see what reviewer thinks before doing this.

codecov-io · 2018-02-12T23:38:33Z

Codecov Report

Merging #2237 into master will decrease coverage by 0.23%.
The diff coverage is 87.34%.

@@            Coverage Diff             @@
##           master    #2237      +/-   ##
==========================================
- Coverage   99.08%   98.84%   -0.24%     
==========================================
  Files         100      100              
  Lines        4046     4075      +29     
  Branches      524      524              
==========================================
+ Hits         4009     4028      +19     
- Misses         37       47      +10

Impacted Files	Coverage Δ
packages/mdc-textfield/constants.js	`100% <ø> (ø)`	⬆️
packages/mdc-floating-label/constants.js	`100% <ø> (ø)`
packages/mdc-textfield/foundation.js	`98.8% <100%> (+0.05%)`	⬆️
packages/mdc-floating-label/foundation.js	`100% <100%> (ø)`
packages/mdc-textfield/index.js	`93.38% <55.55%> (-3.11%)`	⬇️
packages/mdc-floating-label/index.js	`60% <60%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd8d8d9...f8a94e7. Read the comment docs.

moog16 · 2018-02-12T23:41:02Z

packages/mdc-floating-label/_mixins.scss

+}
+
+// Used for textarea in case of scrolling
+@mixin mdc-floating-label-background-color_($color) {


I think this needs to be public

moog16 · 2018-02-12T23:41:35Z

packages/mdc-floating-label/_mixins.scss

+  }
+}
+
+@mixin mdc-floating-label-shake_($modifier) {


This is used heavily in text-field, so I think this should actually be made public, along with reasons made in https://github.com/material-components/material-components-web/pull/2237/files#r167720790

…ext-field mixins

…-components/material-components-web into chore/text-field/decouple-label

acdvorak · 2018-02-15T22:59:16Z

packages/mdc-floating-label/README.md

+```
+
+> _NOTE_: Only place a `mdc-floating-label` inside of a text field _if you plan on using
+> Javascript_. Otherwise, the label must go outside of the text-field, as shown below.


Nit: Javascript -> JavaScript

acdvorak · 2018-02-15T22:59:26Z

packages/mdc-floating-label/README.md

+title: "Floating Label"
+layout: detail
+section: components
+excerpt: "The label is a text caption or description for the text field or select."


Nit: "An animated text caption for a text field or select."

acdvorak · 2018-02-15T23:00:34Z

packages/mdc-floating-label/README.md

+#### Single Line, CSS Only
+
+```html
+<label for="text-field-no-js">TextField with no JS: </label>


Nit: Remove trailing space just before </label>

acdvorak · 2018-02-15T23:02:28Z

packages/mdc-floating-label/README.md

+
+Mixin | Description
+--- | ---
+`mdc-floating-label-color($color)` | Customizes the color of the label.


`mdc-floating-label-ink-color($color)` | Customizes the ink color of the label.

"Ink color" === CSS color property (usually)

"Fill color" === CSS background-color property (usually)

acdvorak · 2018-02-15T23:04:29Z

packages/mdc-floating-label/README.md

+--- | ---
+`mdc-floating-label-color($color)` | Customizes the color of the label.
+`mdc-floating-label-fill-color($color)` | Customizes the fill color of the label.
+`mdc-floating-label-invalid-shake-keyframes($modifier, $positionY, $positionX, $scale)` | Creates a shake keyframe animation for invalid label shake. To be used with sass mixin `mdc-floating-label-shake($modifier)`.


Generates a CSS `@keyframes` at-rule for an invalid label shake. Used in conjunction with the `mdc-floating-label-shake-animation` mixin.

Yes that sound much more concise

acdvorak · 2018-02-15T23:26:09Z

packages/mdc-textfield/adapter.js

+  hasLabel() {}
+
+  /**
+   * Get width of label in pixels


Nit: Add period

acdvorak · 2018-02-15T23:26:44Z

packages/mdc-textfield/adapter.js

@@ -146,6 +146,33 @@ class MDCTextFieldAdapter {
   * @param {number} normalizedX
   */
  setLineRippleTransformOrigin(normalizedX) {}
+
+  /**
+   * Shakes the floating label.


What happens if there's no label? Ditto for other methods below.

Hmm good point...we have a guard in the component, but not in the foundation. I think what I'll do is move the guard into the foundation instead.

acdvorak · 2018-02-15T23:27:04Z

packages/mdc-textfield/adapter.js

+
+  /**
+   * Get width of label in pixels
+   * @return {number}


What does this return if hasLabel() is false?

acdvorak · 2018-02-15T23:28:01Z

packages/mdc-textfield/foundation.js

@@ -109,8 +111,8 @@ class MDCTextFieldFoundation extends MDCFoundation {
  init() {
    this.adapter_.addClass(MDCTextFieldFoundation.cssClasses.UPGRADED);
    // Ensure label does not collide with any pre-filled value.
-    if (this.label_ && this.getValue()) {
-      this.label_.styleFloat(
+    if (this.getValue()) {


Should we keep the this.hasLabel() check?

Ditto below

acdvorak · 2018-02-15T23:32:57Z

test/unit/mdc-textfield/foundation.test.js

  input();
-  td.verify(label.styleShake(/* isValid */ true, /* isFocused */ true));
-  td.verify(label.styleFloat(/* value */ '', /* isFocused */ true, /* isBadInput */ false));
+  td.verify(mockAdapter.shakeLabel(/* isValid */ true, /* isFocused */ true));


Let's check with the rest of the team on this, but I would much prefer to use a destructured object instead of individual boolean params.

E.g.:

shakeLabel({isValid: true, isFocused: true})

Seems like the group has spoken and prefers inline comments, what say you?

I think with only 2 properties it is ok, but if there were more it would make more sense.

…l. updated tests

…o float

… methods

acdvorak · 2018-02-22T19:42:01Z

packages/mdc-floating-label/mdc-floating-label.scss

@@ -26,7 +27,7 @@
  bottom: 8px;
  left: 0;
  transform-origin: left top;
-  transition: mdc-text-field-transition(transform), mdc-text-field-transition(color);
+  transition: mdc-floating-label-transition(transform), mdc-floating-label-transition(color);
  cursor: text;

  // stylelint-disable plugin/selector-bem-pattern


Should the block below this comment (@include mdc-rtl(".mdc-text-field")) get moved to text-field?

Keeping it, but removing mdc-text-field. Thanks for catching

acdvorak · 2018-02-22T19:44:58Z

test/unit/mdc-floating-label/mdc-floating-label-foundation.test.js

 suite('MDCFloatingLabelFoundation');

 test('exports cssClasses', () => {
-  assert.isOk('cssClasses' in MDCFloatingLabelFoundation);
+  assert.deepEqual(MDCFloatingLabelFoundation.cssClasses, cssClasses);


Why does isOk() need to be changed to deepEqual()?

Ken said isOk just checks for truthy-ness, while isTrue is more strict and checks for being true (== vs ===). I changed to deepEqual since this covers 2 things:

Existence, which the isOk statement is checking

Equality

Interesting. It looks like our other packages use a mixture of isOk, isTrue, and deepEqual, which seems inconsistent and a bit odd. But OK 🙂

IMO, a deep equality check is unnecessary in this case, because it's literally comparing a value... to itself:

const {cssClasses} = MDCFloatingLabelFoundation; ... assert.deepEqual(MDCFloatingLabelFoundation.cssClasses, cssClasses);

The object destructuring syntax above hides the fact that it's actually doing this under the hood:

assert.deepEqual( MDCFloatingLabelFoundation.cssClasses, MDCFloatingLabelFoundation.cssClasses);

I think the isOk check is probably sufficient for what the test is (presumably) trying to accomplish: making sure that we remember to export cssClasses from the foundation.

@kfranqueiro was saying he wanted to get rid of all isOk's in the test. However I do realize that last line you wrote is what it boils down to.

I suppose equal vs. deepEqual is a wash in this case, but either one protects us from accidentally e.g. copypasting cssClasses to strings and forgetting to actually change what it returns.

And yeah, I was saying to Matt yesterday that at some point when someone has too much time on their hands I'd like to abolish isOk/isNotOk entirely.

acdvorak · 2018-02-22T22:15:59Z

packages/mdc-floating-label/mdc-floating-label.scss

@@ -30,13 +30,11 @@
  transition: mdc-floating-label-transition(transform), mdc-floating-label-transition(color);
  cursor: text;

-  // stylelint-disable plugin/selector-bem-pattern
-  @include mdc-rtl(".mdc-text-field") {
+  @include mdc-rtl() {


Nit: We normally omit empty parens when defining and including Sass mixins.

Our code base is somewhat inconsistent about that, of course, since we don't have a stylelint rule for it, but just FYI 🙂

ah gotcha - thanks :)

acdvorak · 2018-02-27T19:54:10Z

packages/mdc-floating-label/README.md

+`float(shouldFloat: boolean)` | Floats or docks the label, depending on the value of `shouldFloat`.
+`getWidth() => number` | Returns the width of the label element.
+
+\* **N.B.:** Multiple consecutive calls to `shake(true)` will only shake the label once.


Is this still necessary?

It wasn't there before and it seems like people figured out how it worked. I'll remove.

acdvorak · 2018-02-27T19:55:23Z

packages/mdc-floating-label/_mixins.scss

+
+@import "./variables";
+
+@mixin mdc-floating-label-color($color) {


Let's rename this to mdc-floating-label-ink-color for consistency (don't forget to rename in the README too)

acdvorak · 2018-02-27T20:05:07Z

packages/mdc-floating-label/_mixins.scss

+
+@mixin mdc-floating-label-float-position($positionY, $positionX: 0%, $scale: .75) {
+  @if $positionX == 0 {
+    .mdc-floating-label--float-above {


Can this selector get moved above the @if? (And then remove the duplicate selector inside the @else)

acdvorak · 2018-02-27T20:42:45Z

packages/mdc-floating-label/foundation.js

+import MDCFloatingLabelAdapter from './adapter';
+import {cssClasses} from './constants';
+
+


Nit: Remove blank line

acdvorak · 2018-02-27T20:48:13Z

packages/mdc-floating-label/index.js

+ */
+
+import MDCComponent from '@material/base/component';
+


Nit: Remove blank line

acdvorak · 2018-02-27T20:52:35Z

packages/mdc-textfield/_mixins.scss

@@ -101,6 +101,12 @@
  }
 }

+@mixin mdc-text-field-label-color($color) {


Add -ink to mixin name (e.g., mdc-text-field-label-ink-color).

Also, why was this mixin removed from the README?

Looks like a lot of other mixins were not in the text-field readme. Adding them.

acdvorak · 2018-02-27T20:53:59Z

packages/mdc-textfield/_mixins.scss

+    @include mdc-floating-label-color($color);
+  }
+
+  .mdc-text-field__input::placeholder { // placeholder used in place of label on css only version


Replace this line with:

// CSS-only version .mdc-text-field__input::placeholder {

acdvorak · 2018-02-27T21:00:52Z

packages/mdc-floating-label/_mixins.scss

+
+// Used for textarea in case of scrolling
+@mixin mdc-floating-label-fill-color($color) {
+  .mdc-floating-label {


Remove this selector here (we'll need to add it back to wherever the mixin is used)

acdvorak · 2018-02-27T21:02:51Z

packages/mdc-textfield/_variables.scss

+$mdc-text-field-outlined-with-leading-icon-label-position-x: 32px;
+$mdc-text-field-outlined-dense-with-leading-icon-label-position-x: 21px;
+$mdc-text-field-textarea-label-position-y: 50%;
+// Note that the scale factor is an eyeball'd approximation of what's shown in the mocks.


Nit: "eyeballed"

acdvorak · 2018-02-28T16:14:32Z

demos/text-field.scss

@@ -28,7 +28,7 @@
  @include mdc-text-field-hover-bottom-line-color($hover-border);
  @include mdc-text-field-line-ripple-color($focused-border);
  @include mdc-text-field-ink-color(black);
-  @include mdc-text-field-label-color(rgba(blue, .5));


My bad - I didn't realize this mixin already existed. Let's undo the rename since it would be a breaking change unrelated to this PR.

acdvorak

Just need to add some parameter prefixes and fix a few nits, otherwise LGTM! Nice job Matt!

Looks like Travis is being flaky - I tested locally and everything passed.

acdvorak · 2018-02-28T18:31:00Z

packages/mdc-floating-label/README.md

+
+Method Signature | Description
+--- | ---
+`shake(shouldShake: boolean)` | Shakes or stops shaking the label, depending on the value of `shouldShake`.*


Nit: Remove trailing *

acdvorak · 2018-02-28T18:32:03Z

packages/mdc-floating-label/_mixins.scss

+}
+
+// Used for textarea in case of scrolling
+@mixin mdc-floating-label-fill-color($color) {


Nit: Move this mixin just after mdc-floating-label-ink-color

acdvorak · 2018-02-28T18:34:30Z

packages/mdc-floating-label/package.json

+    "material components",
+    "material design",
+    "floatinglabel",
+    "floating-label"


Nit: Replace - with a space

acdvorak · 2018-02-28T18:35:36Z

packages/mdc-textfield/_mixins.scss

@@ -73,7 +73,9 @@
    @include mdc-text-field-textarea-fill-color_($color);
    // Automatically add label background color the same color as well to ensure


Nit: Add a blank line before this comment

acdvorak · 2018-02-28T18:39:46Z

packages/mdc-textfield/mdc-text-field.scss

  opacity: 1;
 }
+
+@include mdc-floating-label-shake-keyframes(box, $mdc-text-field-box-label-position-y);


The first parameter of all of these keyframes mixins ($modifier) should probably be
prefixed with text-field- to avoid future collisions with mdc-select.

E.g., text-field-box.

Other references to the keyframe names will also need to be updated.

…nts/material-components-web#2237

@alternate

commit f17e0d3 Author: Will Ernest <34519388+williamernest@users.noreply.github.com> Date: Thu Mar 8 13:20:48 2018 -0500 fix(text-field): Clicking label should focus textfield (#2353) commit 77b15f4 Author: Bonnie Zhou <bzbee003@gmail.com> Date: Wed Mar 7 16:29:57 2018 -0800 refactor(button): Remove compact variant (#2361) BREAKING CHANGE: The compact variant of MDC Button is removed. commit 35a5cfc Author: Will Ernest <34519388+williamernest@users.noreply.github.com> Date: Tue Mar 6 19:54:23 2018 -0500 fix(toolbar): Fix colors for svg icons. Update custom-toolbar demo (#2331) SVG icons in the toolbar will now use the same color as the font icons. commit dc52201 Author: Andrew C. Dvorak <acdvorak@gmail.com> Date: Tue Mar 6 16:00:12 2018 -0800 fix(theme): Move @alternate annotations for Closure Stylesheets (#2355) `@alternate` annotations need to come before the _second_ property. Otherwise, Closure Compiler strips the first property (it does not output it at all). commit 3c04419 Author: aprigogin <17075403+aprigogin@users.noreply.github.com> Date: Tue Mar 6 14:29:12 2018 -0800 fix(button): icon in rtl should have margin right flipped. (#2346) commit b9000a4 Author: Cory Reed <swashcap@gmail.com> Date: Tue Mar 6 07:37:40 2018 -0800 fix(demos): Correct RTL/LTR toggling in demos in Safari (#2348) commit ab85736 Author: Andrew C. Dvorak <acdvorak@gmail.com> Date: Mon Mar 5 19:00:11 2018 -0500 fix: Use `var` instead of `const` in menu demo (#2345) Safari 9.x and IE 10 do not support `const` commit dc3d69f Author: aprigogin <17075403+aprigogin@users.noreply.github.com> Date: Mon Mar 5 15:22:31 2018 -0800 fix(rtl): Adding noflip annotations to fix downstream rtl issues (#2344) * fix(rtl): Adding noflip annotations to fix downstream rtl issues * fix(rtl): remove changes to button, will be in separate PR * fix(rtl): remove changes to button, will be in separate PR - second attempt. * fix(rtl): removed extra whitespace commit eb4138e Author: Patrick RoDee <prodee@google.com> Date: Mon Mar 5 14:10:46 2018 -0800 docs: Update CHANGELOG.md commit f478610 Author: Patrick RoDee <prodee@google.com> Date: Mon Mar 5 14:10:30 2018 -0800 chore: Publish commit 78408bb Author: Andrew C. Dvorak <acdvorak@gmail.com> Date: Mon Mar 5 16:13:02 2018 -0500 fix: Use `var` instead of `const` in demos/ready.js (#2343) Safari 9.x and IE 10 do not support `const`, and `ready.js` is not transpiled to ES5. commit 49a9449 Author: Will Ernest <34519388+williamernest@users.noreply.github.com> Date: Mon Mar 5 12:21:54 2018 -0500 chore(select): Fix JS example in Readme (#2332) commit bc17291 Author: Will Ernest <34519388+williamernest@users.noreply.github.com> Date: Fri Mar 2 13:21:07 2018 -0500 feat(top app bar): Add short top app bar always collapsed feature (#2327) commit 0ba7d10 Author: Matty Goo <mattgoo@google.com> Date: Fri Mar 2 11:33:19 2018 -0500 fix(text-field): disable validation check in setRequired (#2201) BREAKING CHANGE: removed setRequired and isRequired from foundation. commit c14d244 Author: Will Ernest <34519388+williamernest@users.noreply.github.com> Date: Fri Mar 2 10:37:18 2018 -0500 chore(select): Fix ID values in demo (#2330) Remove unused ID and changed duplicated ID values. Also fixed the parentheses in RTL. commit ecf4060 Author: Bonnie Zhou <bzbee003@gmail.com> Date: Thu Mar 1 16:38:41 2018 -0500 feat(chips): Change chip color when selected (#2329) BREAKING CHANGE: The `mdc-chip--activated` class, `mdc-chip-activated-ink-color` Sass mixin, and the `toggleActive` methods on `MDCChip`/`MDCChipSet` have been renamed to `mdc-chip--selected`, `mdc-chip-selected-ink-color`, and `toggleSelected`, respectively. commit 4b24b51 Author: Matty Goo <mattgoo@google.com> Date: Wed Feb 28 15:20:19 2018 -0500 chore(floating-label): separate label module from text-field (#2237) BREAKING CHANGE: must use `.mdc-floating-label` selector instead of `.mdc-text-field__label` commit fd8d8d9 Author: Will Ernest <34519388+williamernest@users.noreply.github.com> Date: Wed Feb 28 14:21:55 2018 -0500 feat(top-app-bar): Implement short top app bar (#2290) Adds the short top app bar variant to the top app bar. commit a9f9bf2 Author: Kenneth G. Franqueiro <kfranqueiro@users.noreply.github.com> Date: Wed Feb 28 13:06:41 2018 -0500 docs(select): Fix front matter for label sub-component (#2323)

Matt Goo added 12 commits February 6, 2018 13:55

chore(floating-label): moved floating-label to new package and integr…

a9d6c3c

…ate with mdc-text-field

chore(floating-label): changed all css classes to floating-label

9b750cd

WIP- JS tests

Merge branch 'master' into chore/text-field/decouple-label

4b01134

fix(floating-label): fixed all tests

5a4500f

chore(floating-label): created test directory

324a638

fix(floating-label): removed label foundation from text-field

51f16f6

Merge branch 'master' into chore/text-field/decouple-label

af02b19

fix(floating-label): tests

6f9abdf

Merge branch 'master' into chore/text-field/decouple-label

028c00d

fix(floating-label): updated readmes to reflect changes to floating-l…

024ff39

…abel

fix(floating-label): closure annotation

2f72c61

Merge branch 'master' into chore/text-field/decouple-label

c2f6b95

moog16 commented Feb 12, 2018

View reviewed changes

Matt Goo added 2 commits February 12, 2018 15:26

chore(floating-label): moved text-field-placeholder css rule into tex…

f452125

…t-field

Merge branch 'chore/text-field/decouple-label' of github.com:material…

f00ef39

…-components/material-components-web into chore/text-field/decouple-label

moog16 commented Feb 12, 2018

View reviewed changes

Matt Goo added 4 commits February 12, 2018 16:30

chore(text-field): moved invalid label keyframe animation shakes to t…

4a9846c

…ext-field mixins

fix(text-field): removed export of floating label

1f2cf62

Merge branch 'master' into chore/text-field/decouple-label

ab8b035

fix(text-field): closure annotations

040f739

acdvorak self-assigned this Feb 13, 2018

moog16 mentioned this pull request Feb 15, 2018

select(refactor): decouple label from select #2244

Merged

Matt Goo added 3 commits February 15, 2018 14:28

Merge branch 'chore/text-field/decouple-label' of github.com:material…

d3871a3

…-components/material-components-web into chore/text-field/decouple-label

Merge branch 'master' into chore/text-field/decouple-label

252ffc4

fix(floating-label): sass compliation failure

43bd881

acdvorak suggested changes Feb 15, 2018

View reviewed changes

fix(text-field): updated foundation methods to guard against !hasLabe…

9b627e2

…l. updated tests

Matt Goo added 6 commits February 21, 2018 10:43

fix(floating-label): rename from styleShake to shake and styleFloat t…

ce05cda

…o float

Merge branch 'master' into chore/text-field/decouple-label

1a0aa6c

Merge branch 'master' into chore/text-field/decouple-label

7f69180

fix(floating-label): moved animationend listeners to the init/destroy…

f8ca6f1

… methods

fix(floating-label): fix floating label animation function

161e40a

Merge branch 'master' into chore/text-field/decouple-label

d6a5606

acdvorak reviewed Feb 22, 2018

View reviewed changes

Matt Goo added 3 commits February 22, 2018 12:59

fix(floating-label): fixed rtl for floating-label

eb3893f

fix(floating-label): updated floating label comments

da53da7

Merge branch 'master' into chore/text-field/decouple-label

ead024d

acdvorak reviewed Feb 22, 2018

View reviewed changes

Matt Goo added 5 commits February 22, 2018 14:26

fix(floating-label): remove empty parens from scss mixins

78f5b2d

Merge branch 'master' into chore/text-field/decouple-label

8a05219

fix(floating-label): fixed some typos and empty white space

67c1ab8

Merge branch 'master' into chore/text-field/decouple-label

d7e6962

Merge branch 'master' into chore/text-field/decouple-label

6fdbafc

acdvorak suggested changes Feb 27, 2018

View reviewed changes

fix(floating-label): fixed readme

f03ca0e

acdvorak reviewed Feb 28, 2018

View reviewed changes

Matt Goo added 3 commits February 28, 2018 12:41

fix(text-field): reverted sass mixin name change to ...-label-ink-color

957fa3c

Merge branch 'master' into chore/text-field/decouple-label

7d3a17c

Merge branch 'master' into chore/text-field/decouple-label

5247b43

acdvorak approved these changes Feb 28, 2018

View reviewed changes

Matt Goo added 2 commits February 28, 2018 14:33

fix(text-field): renamed shake animation names and updated readme

cf75c3b

Merge branch 'master' into chore/text-field/decouple-label

f8a94e7

moog16 merged commit 4b24b51 into master Feb 28, 2018

moog16 deleted the chore/text-field/decouple-label branch February 28, 2018 20:20

danielweck added a commit to readium/r2-testapp-js that referenced this pull request Mar 7, 2018

Material Design Web Components, breaking change, see material-compone…

3bef5f0

…nts/material-components-web#2237

MrChriZ mentioned this pull request Apr 23, 2018

mdc-textfield floating label classname change aonawale/ember-material-components#9

Open


		@mixin mdc-text-field-label-float_($positionY, $positionX: 0%, $scale: .75) {
		@mixin mdc-floating-label-position_($positionY, $positionX: 0%, $scale: .75) {


		// Private

		@mixin mdc-floating-label-invalid-shake-keyframes_($modifier, $positionY, $positionX: 0%, $scale: .75) {


		@import "./variables";

		@mixin mdc-floating-label-color($color) {

		import MDCFloatingLabelAdapter from './adapter';
		import {cssClasses} from './constants';

		@@ -73,7 +73,9 @@
		@include mdc-text-field-textarea-fill-color_($color);
		// Automatically add label background color the same color as well to ensure

chore(floating-label): separate label module from text-field #2237

chore(floating-label): separate label module from text-field #2237

Conversation

moog16 commented Feb 12, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codecov-io commented Feb 12, 2018 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

moog16 Feb 16, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

moog16 Feb 22, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kfranqueiro Feb 22, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

acdvorak left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

moog16 commented Feb 12, 2018 •

edited

Loading

codecov-io commented Feb 12, 2018 •

edited

Loading

moog16 Feb 16, 2018 •

edited

Loading

moog16 Feb 22, 2018 •

edited

Loading

kfranqueiro Feb 22, 2018 •

edited

Loading