fix(select): Fix floating label for pre-selected option #2306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
williamernest
changed the title
Codecov Report
@@ Coverage Diff @@
## master #2306 +/- ##
==========================================
+ Coverage 99.07% 99.07% +<.01%
==========================================
Files 99 99
Lines 4004 4007 +3
Branches 515 516 +1
==========================================
+ Hits 3967 3970 +3
Misses 37 37
Continue to review full report at Codecov.
|
acdvorak
approved these changes
Feb 27, 2018
demos/select.html
Outdated
| setSelectedCb.addEventListener('change', function() { | ||
| select.selectedIndex = this.checked ? 0 : -1; | ||
| }); | ||
|
|
demos/select.html
Outdated
| @@ -196,6 +204,8 @@ <h2 class="mdc-typography--title">Select box</h2> | |||
| var rtlCb = document.getElementById('rtl'); | |||
| var alternateColorsCb = document.getElementById('alternate-colors'); | |||
| var disabledCb = document.getElementById('disabled'); | |||
| var setSelectedCb = document.getElementById('set-selected-checkbox'); | |||
|
|
|||
williamernest
force-pushed
the
fix/select/fix-floating-label
branch
from
0984f22
to
a8206cb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #2282
Added tests and demo to check for regression.