fix(scripts): Ensure determine-pkg-versions outputs correct info #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
traviskaufman
commented
Feb 6, 2017
•
traviskaufman
commented
- Ensure new version output by determine-pkg-versions is correct
- Ensure proper publishConfig flags are sent to UpdatedPackagesCollector
|
@yeelan0319 actually going to make a few more changes here, so feel free to hold off on the review until I update the PR 😄 thanks! |
- Ensure new version output by determine-pkg-versions is correct - Ensure proper publishConfig flags are sent to UpdatedPackagesCollector
traviskaufman
force-pushed
the
hotfix/ensure-determine-pkg-versions-outputs-correct-default-version
branch
from
1428761
to
a384e66
Compare
|
@yeelan0319 updated! Feel free to review |
traviskaufman
changed the title
|
Cool. I will give it a look tomorrow morning 👍 |
…ts-correct-default-version
…ts-correct-default-version
|
TravisCI seems to be hanging on this PR...last two builds passed and branch update was merged in cleanly so going to squash and merge. |
traviskaufman
deleted the
hotfix/ensure-determine-pkg-versions-outputs-correct-default-version
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.