feat(icon-button): Add new package #2748
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,271 @@ | ||
| <!DOCTYPE html> | ||
|
There was a problem hiding this comment. I appreciate that this file was added (especially in this case where it's effectively replacing an existing component), but is it feasible to fast-follow this PR with screenshot testing page(s)? |
||
| <!-- | ||
| Copyright 2016 Google Inc. All rights reserved. | ||
|
There was a problem hiding this comment. Might want to do a copyright year check on new files |
||
|
|
||
| Licensed under the Apache License, Version 2.0 (the "License"); | ||
| you may not use this file except in compliance with the License. | ||
| You may obtain a copy of the License at | ||
|
|
||
| https://www.apache.org/licenses/LICENSE-2.0 | ||
|
|
||
| Unless required by applicable law or agreed to in writing, software | ||
| distributed under the License is distributed on an "AS IS" BASIS, | ||
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| See the License for the specific language governing permissions and | ||
| limitations under the License | ||
| --> | ||
| <html> | ||
| <head> | ||
| <meta charset="utf-8"> | ||
| <title>Icon Button - Material Components Demo</title> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1"> | ||
| <link rel="icon" type="image/png" href="/images/logo_components_color_2x_web_48dp.png"> | ||
| <link rel="stylesheet" href="/assets/icon-button.css"> | ||
| <link rel="stylesheet" href="https://fonts.googleapis.com/css?family=Roboto+Mono"> | ||
| <link rel="stylesheet" href="https://fonts.googleapis.com/css?family=Roboto:300,400,500"> | ||
| <link rel="stylesheet" href="https://fonts.googleapis.com/icon?family=Material+Icons"> | ||
| <link rel="stylesheet" href="https://cdnjs.cloudflare.com/ajax/libs/font-awesome/4.6.3/css/font-awesome.css"> | ||
| <script src="/ready.js"></script> | ||
| </head> | ||
| <body class="mdc-typography"> | ||
| <header class="mdc-toolbar mdc-toolbar--fixed"> | ||
| <div class="mdc-toolbar__row"> | ||
| <section class="mdc-toolbar__section mdc-toolbar__section--align-start"> | ||
| <a href="/" class="catalog-back mdc-toolbar__menu-icon"><i class="material-icons"></i></a> | ||
| <span class="mdc-toolbar__title catalog-title">Icon Buttons</span> | ||
| </section> | ||
| </div> | ||
| </header> | ||
| <main> | ||
| <div class="mdc-toolbar-fixed-adjust"></div> | ||
| <section class="hero"> | ||
| <div class="demo-wrapper"> | ||
| <i class="mdc-icon-button material-icons" | ||
|
There was a problem hiding this comment. Should we enforce that all mdc-icon-buttons use the (And also like Button, |
||
| role="button" | ||
| aria-label="Add to favorites" | ||
| aria-pressed="false" | ||
| tabindex="0" | ||
| data-toggle-on='{"content": "favorite", "label": "Remove From Favorites"}' | ||
| data-toggle-off='{"content": "favorite_border", "label": "Add to Favorites"}'> | ||
| <!-- Prevent FOUC by putting the initial content in --> | ||
| favorite_border | ||
| </i> | ||
| </div> | ||
| </section> | ||
|
|
||
| <section class="example"> | ||
| <div> | ||
| <div> | ||
| <h1 class="mdc-typography--headline5">Buttons</h1> | ||
| </div> | ||
| <div class="toggle-examples-container"> | ||
| <div class="toggle-example"> | ||
| <h2 class="mdc-typography--headline6">Material Icons</h2> | ||
| <div class="demo-wrapper"> | ||
| <a class="mdc-icon-button material-icons" | ||
| role="button" | ||
| aria-label="Add to favorites" | ||
| aria-pressed="false" | ||
| tabindex="0"> | ||
|
There was a problem hiding this comment.
There was a problem hiding this comment.
|
||
| favorite | ||
| </a> | ||
| <span class="mdc-icon-button material-icons" | ||
| role="button" | ||
| aria-label="Transit directions" | ||
| aria-pressed="false" | ||
| tabindex="0"> | ||
| directions_transit | ||
| </span> | ||
| <button class="mdc-icon-button material-icons" | ||
| role="button" | ||
| aria-label="Airplane Mode active" | ||
| aria-pressed="false" | ||
| tabindex="0"> | ||
| airplanemode_active | ||
| </button> | ||
| </div> | ||
| </div> | ||
|
|
||
| <div class="toggle-example"> | ||
| <h2 class="mdc-typography--headline6">SVG Icon</h2> | ||
| <div class="demo-wrapper"> | ||
| <button class="mdc-icon-button" | ||
| role="button" | ||
|
There was a problem hiding this comment.
|
||
| aria-label="Add to favorites" | ||
| aria-pressed="false" | ||
| tabindex="0"> | ||
| <svg xmlns="http://www.w3.org/2000/svg" width="24px" height="24px" viewBox="0 0 24 24"> | ||
|
There was a problem hiding this comment. Do we need width and height hard-coded inline here or should CSS cover this? |
||
| <path fill="none" d="M0 0h24v24H0z"/> | ||
| <path d="M23 12c0-6.07-4.93-11-11-11S1 5.93 1 12s4.93 11 11 11 11-4.93 11-11zM5 17.64C3.75 16.1 3 14.14 3 12c0-2.13.76-4.08 2-5.63v11.27zM17.64 5H6.36C7.9 3.75 9.86 3 12 3s4.1.75 5.64 2zM12 14.53L8.24 7h7.53L12 14.53zM17 9v8h-4l4-8zm-6 8H7V9l4 8zm6.64 2c-1.55 1.25-3.51 2-5.64 2s-4.1-.75-5.64-2h11.28zM21 12c0 2.14-.75 4.1-2 5.64V6.37c1.24 1.55 2 3.5 2 5.63z"/> | ||
| </svg> | ||
| </button> | ||
| </div> | ||
| </div> | ||
|
|
||
| <div class="toggle-example"> | ||
| <h2 class="mdc-typography--headline6">Disabled Buttons</h2> | ||
| <div class="demo-wrapper"> | ||
| <span class="mdc-icon-button mdc-icon-button--disabled material-icons" | ||
|
There was a problem hiding this comment. See previous comment RE potentially limiting to |
||
| role="button" | ||
| aria-label="Transit directions" | ||
| aria-pressed="false" | ||
| tabindex="0"> | ||
|
There was a problem hiding this comment. These shouldn't have tabindex if they're disabled. |
||
| directions_transit | ||
| </span> | ||
| <button class="mdc-icon-button material-icons" | ||
| role="button" | ||
| aria-label="Airplane Mode active" | ||
| aria-pressed="false" | ||
| disabled | ||
| tabindex="0"> | ||
| airplanemode_active | ||
| </button> | ||
| <button class="mdc-icon-button" | ||
| role="button" | ||
| aria-label="Add to favorites" | ||
| aria-pressed="false" | ||
| disabled | ||
| tabindex="0"> | ||
| <svg xmlns="http://www.w3.org/2000/svg" width="24px" height="24px" viewBox="0 0 24 24"> | ||
| <path fill="none" d="M0 0h24v24H0z"/> | ||
| <path d="M23 12c0-6.07-4.93-11-11-11S1 5.93 1 12s4.93 11 11 11 11-4.93 11-11zM5 17.64C3.75 16.1 3 14.14 3 12c0-2.13.76-4.08 2-5.63v11.27zM17.64 5H6.36C7.9 3.75 9.86 3 12 3s4.1.75 5.64 2zM12 14.53L8.24 7h7.53L12 14.53zM17 9v8h-4l4-8zm-6 8H7V9l4 8zm6.64 2c-1.55 1.25-3.51 2-5.64 2s-4.1-.75-5.64-2h11.28zM21 12c0 2.14-.75 4.1-2 5.64V6.37c1.24 1.55 2 3.5 2 5.63z"/> | ||
| </svg> | ||
| </button> | ||
| </div> | ||
| </div> | ||
| </div> | ||
| </div> | ||
| </section> | ||
|
|
||
| <section class="example"> | ||
| <div> | ||
| <div> | ||
| <h1 class="mdc-typography--headline5">Button Toggles</h1> | ||
| </div> | ||
| <div class="toggle-examples-container"> | ||
| <div class="toggle-example"> | ||
| <h2 class="mdc-typography--headline6">Using Material Icons</h2> | ||
| <div class="demo-wrapper"> | ||
| <i id="add-to-favorites" | ||
| class="mdc-icon-button material-icons" | ||
| role="button" | ||
| aria-label="Add to favorites" | ||
| aria-pressed="false" | ||
| tabindex="0" | ||
| data-toggle-on='{"content": "favorite", "label": "Remove From Favorites"}' | ||
| data-toggle-off='{"content": "favorite_border", "label": "Add to Favorites"}'> | ||
| <!-- Prevent FOUC by putting the initial content in --> | ||
| favorite_border | ||
| </i> | ||
| </div> | ||
| <p>Favorited? <span id="favorited-status">no</span></p> | ||
| </div> | ||
|
|
||
| <div class="toggle-example"> | ||
| <h2 class="mdc-typography--headline6">Using Font Awesome</h2> | ||
| <div class="demo-wrapper"> | ||
| <span class="mdc-icon-button mdc-icon-button--on" | ||
| role="button" | ||
| aria-label="Unstar this item" | ||
| aria-pressed="true" | ||
| tabindex="0" | ||
| data-icon-inner-selector=".fa" | ||
| data-toggle-on='{"cssClass": "fa-star", "label": "Unstar this item"}' | ||
| data-toggle-off='{"cssClass": "fa-star-o", "label": "Star this item"}'> | ||
| <i class="fa fa-star" aria-hidden="true"></i> | ||
| </span> | ||
| </div> | ||
| </div> | ||
|
|
||
| <div class="toggle-example"> | ||
| <h2 class="mdc-typography--headline6">Disabled Icons</h2> | ||
| <div class="demo-wrapper"> | ||
| <i class="mdc-icon-button mdc-icon-button--disabled material-icons" | ||
| role="button" | ||
| aria-label="Add to favorites" | ||
| aria-pressed="false" | ||
| aria-disabled="true" | ||
| tabindex="-1" | ||
| data-toggle-on='{"content": "favorite", "label": "Remove From Favorites"}' | ||
| data-toggle-off='{"content": "favorite_border", "label": "Add to Favorites"}'> | ||
| favorite_border | ||
| </i> | ||
| </div> | ||
| </div> | ||
| </div> | ||
|
|
||
| <div class="toggle-example"> | ||
| <h2 class="mdc-typography--headline6">Additional Color Combinations</h2> | ||
| <div id="demo-color-combos"> | ||
| <div id="light-on-bg" class="demo-color-combo"> | ||
| <div> | ||
| <i class="mdc-icon-button material-icons mdc-theme--on-primary" | ||
| role="button" | ||
| aria-label="Add to favorites" | ||
| aria-pressed="false" | ||
| tabindex="0" | ||
| data-toggle-on='{"content": "favorite", "label": "Remove From Favorites"}' | ||
| data-toggle-off='{"content": "favorite_border", "label": "Add to Favorites"}'> | ||
| favorite_border | ||
| </i> | ||
| </div> | ||
| <div class="mdc-theme--on-primary">Light icon on background</div> | ||
| </div> | ||
| <div id="dark-on-bg" class="demo-color-combo"> | ||
| <div class="mdc-theme--primary"> | ||
| <i class="mdc-icon-button material-icons" | ||
| role="button" | ||
| aria-label="Add to favorites" | ||
| aria-pressed="false" | ||
| tabindex="0" | ||
| data-toggle-on='{"content": "favorite", "label": "Remove From Favorites"}' | ||
| data-toggle-off='{"content": "favorite_border", "label": "Add to Favorites"}'> | ||
| favorite_border | ||
| </i> | ||
| </div> | ||
| <div>Dark icon on background</div> | ||
| </div> | ||
| <div id="custom-color-combo" class="demo-color-combo"> | ||
| <div> | ||
| <i class="mdc-icon-button material-icons" | ||
| role="button" | ||
| aria-label="Add to favorites" | ||
| aria-pressed="false" | ||
| tabindex="0" | ||
| data-toggle-on='{"content": "favorite", "label": "Remove From Favorites"}' | ||
| data-toggle-off='{"content": "favorite_border", "label": "Add to Favorites"}'> | ||
| favorite_border | ||
| </i> | ||
| </div> | ||
| <div>Custom color</div> | ||
| </div> | ||
| </div> | ||
| </div> | ||
| </div> | ||
| </section> | ||
| </main> | ||
|
|
||
| <script src="/assets/material-components-web.js" async></script> | ||
| <script> | ||
| demoReady(function() { | ||
| var nodes = document.querySelectorAll('.mdc-icon-button[data-toggle-on]'); | ||
| for (var i = 0, node; node = nodes[i]; i++) { | ||
| mdc.iconButton.MDCIconButtonToggle.attachTo(node); | ||
| } | ||
|
|
||
| var buttons = document.querySelectorAll('.mdc-icon-button:not([data-toggle-on])'); | ||
| for (var x = 0, button; button = buttons[x]; x++) { | ||
| mdc.ripple.MDCRipple.attachTo(button, {isUnbounded: true}); | ||
| } | ||
|
|
||
| var addToFavorites = document.getElementById('add-to-favorites'); | ||
| var favoritedStatus = document.getElementById('favorited-status'); | ||
| addToFavorites.addEventListener('MDCIconButtonToggle:change', function(evt) { | ||
| console.log(evt); | ||
| var newStatus = evt.detail.isOn ? 'yes' : 'no'; | ||
| favoritedStatus.textContent = newStatus; | ||
| }); | ||
| }); | ||
| </script> | ||
| </body> | ||
| </html> | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't we also add
mdc-icon-buttonto the othermdc-card__action--iconelements to make sure it works for them? (Which would also affect MDC Card documentation, and might mean there are styles we can pull out of Card ifmdc-icon-buttonalready covers it now)Need to be careful to only instantiate MDCIconButtonToggle for the actual toggle buttons though, and not all icon buttons... This might actually point to a developer ergonomics problem, if it becomes difficult to programmatically distinguish things we want to be toggle-able from things that aren't.