fix(text-field): Update caret color to match spec #2894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2894 +/- ##
======================================
Coverage 98.3% 98.3%
======================================
Files 101 101
Lines 4375 4375
Branches 564 564
======================================
Hits 4301 4301
Misses 74 74Continue to review full report at Codecov.
|
bonniezhou
suggested changes
Jun 11, 2018
packages/mdc-textfield/_mixins.scss
Outdated
| @@ -124,6 +124,12 @@ | |||
| } | |||
| } | |||
|
|
|||
| @mixin mdc-text-field-caret-color($color) { | |||
| &:not(.mdc-text-field--disabled) { | |||
There was a problem hiding this comment.
I think we can remove the not selector and the private mixin, since disabled text fields don't have a caret.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #2819
Added a mixin to support modifying the color.